feat(attributes): Complete the gen_ai.tool.definitions alias group - #595
Merged
Conversation
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Descriptions
Names
Other
Bug Fixes 🐛
Internal Changes 🔧Deps
Names
Other
🤖 This preview updates automatically when you update the PR. |
JPeer264
marked this pull request as ready for review
August 27, 2026 16:45
JPeer264
requested review from
a team,
Lms24,
cleptric,
mjq and
nsdeschenes
as code owners
August 27, 2026 16:45
JPeer264
force-pushed
the
jp/conv-gen-ai-tool-definitions-alias
branch
from
August 27, 2026 16:49
ab9324d to
640063f
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
JPeer264
force-pushed
the
jp/conv-gen-ai-tool-definitions-alias
branch
from
August 27, 2026 17:29
640063f to
684df12
Compare
Lms24
reviewed
Aug 28, 2026
Lms24
left a comment
Lms24
left a comment
Member
There was a problem hiding this comment.
The gen_ai aliases look correct but for the ai ones please see the Seer comment
JPeer264
force-pushed
the
jp/conv-gen-ai-tool-definitions-alias
branch
from
August 28, 2026 11:49
684df12 to
67174a2
Compare
JPeer264
force-pushed
the
jp/conv-gen-ai-tool-definitions-alias
branch
from
August 28, 2026 12:12
67174a2 to
906fc56
Compare
JPeer264
force-pushed
the
jp/conv-gen-ai-tool-definitions-alias
branch
from
August 28, 2026 12:26
906fc56 to
c424824
Compare
Lms24
approved these changes
Sep 3, 2026
JPeer264
force-pushed
the
jp/conv-gen-ai-tool-definitions-alias
branch
2 times, most recently
from
September 9, 2026 09:28
49d3733 to
ef2fb47
Compare
`gen_ai.request.available_tools`, `ai.tools` and `ai.prompt.tools` all replace onto `gen_ai.tool.definitions`, but none of the four named the others. `gen_ai.request.available_tools` even carried an empty `alias` array, and `ai.tools` had none at all, which is why the symmetry test stayed green. All four now list each other. Replaced by getsentry/sentry-javascript#22820 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…initions The ai.tools and ai.prompt.tools attributes are string[], while gen_ai.tool.definitions and gen_ai.request.available_tools are string. Type-diverging attributes are not aliases, so keep only the deprecation replacement chain for the ai.* attributes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Lms24
force-pushed
the
jp/conv-gen-ai-tool-definitions-alias
branch
from
September 9, 2026 18:02
ef2fb47 to
a80026e
Compare
Comment on lines
7
to
+13
| }, | ||
| "is_in_otel": true, | ||
| "example": "[{\"type\": \"function\", \"name\": \"get_current_weather\", \"description\": \"Get the current weather in a given location\", \"parameters\": {\"type\": \"object\", \"properties\": {\"location\": {\"type\": \"string\", \"description\": \"The city and state, e.g. San Francisco, CA\"}, \"unit\": {\"type\": \"string\", \"enum\": [\"celsius\", \"fahrenheit\"]}}, \"required\": [\"location\", \"unit\"]}}]", | ||
| "alias": ["gen_ai.request.available_tools"], | ||
| "visibility": "public", | ||
| "changelog": [ | ||
| { |
There was a problem hiding this comment.
Bug: The logic in deriveAttributeKeyChains filters out deprecated aliases, creating an asymmetric chain expansion despite symmetric alias definitions in the JSON, causing inconsistent attribute chains.
Severity: MEDIUM
Suggested Fix
The logic in deriveAttributeKeyChains should be adjusted to handle symmetric aliases involving deprecated attributes correctly. The filtering that removes deprecated aliases from a stable attribute's alias expansion should be re-evaluated to ensure that chain membership remains consistent across all members of an alias group, regardless of their deprecation status.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: model/attributes/gen_ai/gen_ai__tool__definitions.json#L7-L13
Potential issue: The introduction of a symmetric alias between the stable attribute
`gen_ai.tool.definitions` and the deprecated attribute `gen_ai.request.available_tools`
creates an inconsistency in how attribute chains are generated. The
`deriveAttributeKeyChains` function filters out deprecated aliases when expanding the
chain for a stable attribute. As a result, the chain for `gen_ai.tool.definitions` will
not include `gen_ai.request.available_tools`. Conversely,
`gen_ai.request.available_tools`, being a rewriting deprecation, will join the chain of
its replacement, `gen_ai.tool.definitions`. This asymmetry means the two attributes will
not agree on their chain membership, which is expected to cause the test 'agrees on
chain membership between every pair of chained attributes' to fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gen_ai.request.available_tools,ai.toolsandai.prompt.toolsall replace ontogen_ai.tool.definitions, but none of the four named the others.gen_ai.request.available_toolseven carried an emptyaliasarray andai.toolshad none at all, which is why the symmetry test stayed green. All four now list each other.Supersedes #590, which GitHub auto-closed during a rebase of the stack.
Replaced by getsentry/sentry-javascript#22820