Skip to content

ref: Remove Playstation::envelop and Minidump::envelop helpers - #6317

Merged
tobias-wilfert merged 3 commits into
getsentry:masterfrom
pierceroberts:proberts-rm-envelop-fn
Aug 31, 2026
Merged

ref: Remove Playstation::envelop and Minidump::envelop helpers#6317
tobias-wilfert merged 3 commits into
getsentry:masterfrom
pierceroberts:proberts-rm-envelop-fn

Conversation

@pierceroberts

@pierceroberts pierceroberts commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

This relates to: #5985 (comment)

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@pierceroberts
pierceroberts requested a review from a team as a code owner August 25, 2026 04:42
@tobias-wilfert

Copy link
Copy Markdown
Member

Changelog CI is failing because of the title not matching the convention.

@pierceroberts pierceroberts changed the title Playstation::envelop & Minidump::envelop cleanup ref: Remove Playstation::envelop and Minidump::envelop helpers Aug 28, 2026
@pierceroberts

Copy link
Copy Markdown
Contributor Author

Thanks for calling that out @tobias-wilfert !
I believe I fixed that!
Also I was surprised this didn't require any test deletion!

@tobias-wilfert
tobias-wilfert added this pull request to the merge queue Aug 31, 2026
Merged via the queue into getsentry:master with commit 71b2c6c Aug 31, 2026
50 of 51 checks passed
@tobias-wilfert

Copy link
Copy Markdown
Member

Once again, thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants