Skip to content

[Bug]: Edit clip's Apply is out of view in a non-maximized editor, and a click there closes the dialog without saving #1005

Description

@EtienneLescot

What happens

In the Edit clip dialog, the footer (Reset / Cancel / Apply) sits inside the scrolling body instead of being pinned. In an editor window 794 css px tall (1240×1000 physical at 125 %), the card is clipped at y = 747 while Apply is at 740–774, so Apply is not visible.

A click where Apply should be lands on _modalBackdrop. That closes the dialog and discards the edit (new trim range and crop) with no warning.

You can only reach Apply by wheel-scrolling inside the dialog first. In a maximized window (826 css px) it fits: Apply 742–776, card bottom 777.

Expected

Apply is always visible (pinned footer, or the body scrolls and the footer does not), and a backdrop click does not drop unsaved crop or trim edits silently.

Steps

  1. Size the editor window to about 1240×1000 at 125 % (not maximized).
  2. Double-click a clip → Edit clip, move a grip or pick 1:1.
  3. Look for Apply at the bottom of the card, then click where it is.

Environment

v2.0.0-rc.15 (same code as v2.0.0), Windows 11, 1920×1080 @ 125 %. Found in the rc.15 computer-use pass (#1003).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions