Skip to content

fix: url id resolution on run#1093

Open
amhsirak wants to merge 1 commit into
developfrom
urlid-fix
Open

fix: url id resolution on run#1093
amhsirak wants to merge 1 commit into
developfrom
urlid-fix

Conversation

@amhsirak

@amhsirak amhsirak commented Jun 10, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes
    • Improved run routing to handle cases where expected metadata is unavailable from the service response, ensuring users can successfully navigate to runs in all scenarios.

@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7403ecc9-5f10-4a00-a02e-39ff22063d87

📥 Commits

Reviewing files that changed from the base of the PR and between 11db025 and fc85b16.

📒 Files selected for processing (1)
  • src/pages/MainPage.tsx

Walkthrough

The MainPage component's handleRunRecording flow now ensures a valid robot metadata ID exists for run routing by introducing a fallback mechanism. When the API response lacks a robotMetaId, the flow derives resolvedRobotMetaId from robotMetaId || runningRecordingId and uses that value for state updates and navigation to the run route.

Changes

Recording Navigation ID Resolution

Layer / File(s) Summary
Robot ID fallback resolution
src/pages/MainPage.tsx
The handleRunRecording response handler adds resolvedRobotMetaId with a fallback to runningRecordingId when robotMetaId is missing, then applies that resolved ID to setIds and run route navigation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • getmaxun/maxun#417: The main PR derives a fallback resolvedRobotMetaId when the createAndRunRecording response lacks robotMetaId, aligning with that PR's introduction of robotMetaId in the run creation response and navigation flow.
  • getmaxun/maxun#1017: Both PRs modify MainPage.tsx's createAndRunRecording/handleRunRecording response handling to adjust run routing; the main PR derives resolvedRobotMetaId as a fallback, while that PR adjusts routing logic based on browserId being null.

Suggested labels

Type: Chore

Poem

🐰 A fallback is born with grace,
When robotMetaId leaves an empty space,
We check the recordingId with care,
Navigation flows both fast and fair!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: url id resolution on run' directly relates to the main change: resolving the robotMetaId for URL routing when it's missing from the API response.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch urlid-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant