Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/models.ts
Original file line number Diff line number Diff line change
Expand Up @@ -617,6 +617,7 @@ const SHORT_NAMES: Record<string, string> = {
'gpt-5.4-nano': 'GPT-5.4 Nano',
'gpt-5.4-mini': 'GPT-5.4 Mini',
'gpt-5.4': 'GPT-5.4',
'gpt-5.3-codex-spark': 'GPT-5.3 Codex Spark',
'gpt-5.3-codex': 'GPT-5.3 Codex',
'gpt-5.3': 'GPT-5.3',
'gpt-5.2-pro': 'GPT-5.2 Pro',
Expand Down
1 change: 1 addition & 0 deletions src/providers/codex.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ const modelDisplayNames: Record<string, string> = {
'gpt-5.5': 'GPT-5.5',
'gpt-5.4-mini': 'GPT-5.4 Mini',
'gpt-5.4': 'GPT-5.4',
'gpt-5.3-codex-spark': 'GPT-5.3 Codex Spark',
'gpt-5.3-codex': 'GPT-5.3 Codex',
'gpt-5.2-low': 'GPT-5.2 Low',
'gpt-5.2': 'GPT-5.2',
Expand Down
6 changes: 6 additions & 0 deletions tests/models.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,12 @@ describe('getShortModelName', () => {
expect(getShortModelName('claude-opus-4-8')).toBe('Opus 4.8')
})

// Regression for #461: gpt-5.3-codex-spark must keep its own display name
// rather than collapsing into the shorter gpt-5.3-codex bucket.
it('maps gpt-5.3-codex-spark to its own line (not GPT-5.3 Codex)', () => {
expect(getShortModelName('gpt-5.3-codex-spark')).toBe('GPT-5.3 Codex Spark')
})

// A future version is derived from the id with no hand-maintained entry.
it('derives an unreleased claude version with no SHORT_NAMES entry', () => {
expect(getShortModelName('claude-sonnet-5-2')).toBe('Sonnet 5.2')
Expand Down
12 changes: 12 additions & 0 deletions tests/providers/codex.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -493,3 +493,15 @@ describe('codex provider - forked session dedupe', () => {
expect(tokens).toBe(300)
})
})

describe('codex provider - modelDisplayName', () => {
it('maps gpt-5.3-codex-spark to its own display name (not GPT-5.3 Codex) - fix #461', () => {
const provider = createCodexProvider('/nonexistent/path')
expect(provider.modelDisplayName('gpt-5.3-codex-spark')).toBe('GPT-5.3 Codex Spark')
})

it('still maps the base gpt-5.3-codex to GPT-5.3 Codex', () => {
const provider = createCodexProvider('/nonexistent/path')
expect(provider.modelDisplayName('gpt-5.3-codex')).toBe('GPT-5.3 Codex')
})
})