Skip to content

Set convert unit to big endian for FastScape#7011

Open
anne-glerum wants to merge 1 commit into
geodynamics:mainfrom
anne-glerum:set_convert_unit
Open

Set convert unit to big endian for FastScape#7011
anne-glerum wants to merge 1 commit into
geodynamics:mainfrom
anne-glerum:set_convert_unit

Conversation

@anne-glerum

Copy link
Copy Markdown
Contributor

This PR sets an environment variable in the Dockerfile from which the dealii-master tester image is built. The GFORTRAN_CONVERT_UNIT setting is needed to get correct VTU output from FastScape (see fastscape-lem/fastscapelib-fortran#49). Without it, the output is not readible in ParaView. Although this is not so important for the tester, I would like to include it for completion and in case someone uses the image. Also, the FastScape tests do produce VTU output, but I don't think that is compared.

For all pull requests:

For new features/models or changes of existing features:

  • I have tested my new feature locally to ensure it is correct.
  • I have created a testcase for the new feature/benchmark in the tests/ directory.
  • I have added a changelog entry in the doc/modules/changes directory that will inform other users of my change.

@gassmoeller gassmoeller left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, makes sense. It is also a good reminder for when we include Fastscape into the official ASPECT docker image, that we need to set this variable.

@gassmoeller

Copy link
Copy Markdown
Member

/rebuild

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants