Set convert unit to big endian for FastScape#7011
Open
anne-glerum wants to merge 1 commit into
Open
Conversation
gassmoeller
approved these changes
Jun 17, 2026
gassmoeller
left a comment
Member
There was a problem hiding this comment.
Yes, makes sense. It is also a good reminder for when we include Fastscape into the official ASPECT docker image, that we need to set this variable.
Member
|
/rebuild |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets an environment variable in the Dockerfile from which the dealii-master tester image is built. The GFORTRAN_CONVERT_UNIT setting is needed to get correct VTU output from FastScape (see fastscape-lem/fastscapelib-fortran#49). Without it, the output is not readible in ParaView. Although this is not so important for the tester, I would like to include it for completion and in case someone uses the image. Also, the FastScape tests do produce VTU output, but I don't think that is compared.
For all pull requests:
For new features/models or changes of existing features: