Fix fastscape test output#7002
Open
anne-glerum wants to merge 7 commits into
Open
Conversation
gassmoeller
reviewed
Jun 5, 2026
gassmoeller
left a comment
Member
There was a problem hiding this comment.
Looks good to me. But lets wait with merging this PR until we have resolved all of the test failures. Just in case we have to modify some of the tests again.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the changes described in #6963, the FastScape tests run to completion. This PR updates the test results. The main changes are:
fastscape_test_silt_sand_parametersnow does two more timesteps, but this corresponds to the setEnd time. When I introduced the test I had to increase the end time to get below sea level, I probably forgot to update the results accordingly 😔fastscape_kf_function_in_secondsnow actually has output in seconds instead of years.output-in thestatisticsfile.Concerning the first change, I don't think the recent changes to the mesh deformation functionality changed the order of the element for box geometries. The topography postprocessor outputs do not show more points either. I'll look into it.
For all pull requests:
For new features/models or changes of existing features: