Skip to content

Fix fastscape test output#7002

Open
anne-glerum wants to merge 7 commits into
geodynamics:mainfrom
anne-glerum:fix_fastscape_test_output
Open

Fix fastscape test output#7002
anne-glerum wants to merge 7 commits into
geodynamics:mainfrom
anne-glerum:fix_fastscape_test_output

Conversation

@anne-glerum

@anne-glerum anne-glerum commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

With the changes described in #6963, the FastScape tests run to completion. This PR updates the test results. The main changes are:

  • The number of mesh deformation DOFs increases by a factor ~4.
  • The topography changes significantly (e.g. from 20 to 70 m), this could be related to the change in degrees of freedom.
  • The test fastscape_test_silt_sand_parameters now does two more timesteps, but this corresponds to the set End time. When I introduced the test I had to increase the end time to get below sea level, I probably forgot to update the results accordingly 😔
  • The test fastscape_kf_function_in_seconds now actually has output in seconds instead of years.
  • The output folder names now include output- in the statistics file.
  • Some changes in linear iterations for all solvers.

Concerning the first change, I don't think the recent changes to the mesh deformation functionality changed the order of the element for box geometries. The topography postprocessor outputs do not show more points either. I'll look into it.

For all pull requests:

For new features/models or changes of existing features:

  • I have tested my new feature locally to ensure it is correct.
  • I have created a testcase for the new feature/benchmark in the tests/ directory.
  • I have added a changelog entry in the doc/modules/changes directory that will inform other users of my change.

@gassmoeller gassmoeller left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. But lets wait with merging this PR until we have resolved all of the test failures. Just in case we have to modify some of the tests again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants