Skip to content

Make dynamic core own its core data state#7000

Open
Francyrad wants to merge 1 commit into
geodynamics:mainfrom
Francyrad:dynamic_core_coredata_single_owner
Open

Make dynamic core own its core data state#7000
Francyrad wants to merge 1 commit into
geodynamics:mainfrom
Francyrad:dynamic_core_coredata_single_owner

Conversation

@Francyrad

Copy link
Copy Markdown
Contributor

Summary

  • Remove the duplicated core_data copy from the core statistics postprocessor.
  • Keep DynamicCore as the single owner of the dynamic core restart state.
  • Let core statistics read the current core data directly from the dynamic core boundary temperature plugin when it writes statistics.

Motivation

Follow-up to #6962. Now that the dynamic core boundary temperature plugin serializes its own state, the old postprocessor-side core_data copy is no longer needed and can overwrite the plugin state on restart.

Testing

  • cmake --build build-debug --target aspect -j20
  • cmake --build build-debug-nounity --target aspect -j20
  • ASPECT_SOURCE_DIR=/home/francyrad/Documenti/aspect_debug/aspect_dynamic_core_coredata_single_owner_work ctest --output-on-failure -R '^dynamic_core' -j20
    • dynamic_core passed
    • dynamic_core_fully_solid passed
    • dynamic_core_fully_molten only differs in the last digit of two time values on this local deal.II 9.6.1 build
  • Manual checkpoint/resume smoke test for dynamic_core: restart resumed from the checkpoint and continued with Dynamic core data updated instead of reinitializing the core.
  • Manual smoke test without the core statistics postprocessor: dynamic core ran with velocity statistics only.

@Francyrad

Copy link
Copy Markdown
Contributor Author

@gassmoeller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant