Make dynamic core own its core data state#7000
Open
Francyrad wants to merge 1 commit into
Open
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
core_datacopy from thecore statisticspostprocessor.DynamicCoreas the single owner of the dynamic core restart state.core statisticsread the current core data directly from the dynamic core boundary temperature plugin when it writes statistics.Motivation
Follow-up to #6962. Now that the dynamic core boundary temperature plugin serializes its own state, the old postprocessor-side
core_datacopy is no longer needed and can overwrite the plugin state on restart.Testing
cmake --build build-debug --target aspect -j20cmake --build build-debug-nounity --target aspect -j20ASPECT_SOURCE_DIR=/home/francyrad/Documenti/aspect_debug/aspect_dynamic_core_coredata_single_owner_work ctest --output-on-failure -R '^dynamic_core' -j20dynamic_corepasseddynamic_core_fully_solidpasseddynamic_core_fully_moltenonly differs in the last digit of two time values on this local deal.II 9.6.1 builddynamic_core: restart resumed from the checkpoint and continued withDynamic core data updatedinstead of reinitializing the core.core statisticspostprocessor:dynamic coreran withvelocity statisticsonly.