Skip to content

fix: limit Vec::with_capacity in binary calldata decoder to prevent OOM #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lau90eth wants to merge 2 commits into
base: v0.3-dev
Choose a base branch
from
Open

fix: limit Vec::with_capacity in binary calldata decoder to prevent OOM #320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7207d8f
fix: check empty leader nondet result before indexing data[0]
lau90eth Jun 28, 2026
32dc8e7
fix: limit Vec::with_capacity in bin.rs to prevent OOM
lau90eth Jun 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions executor/crates/calldata/src/bin.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,10 @@ impl Parser<'_> {
if full_size == 0 {
Value::Array(Vec::new())
} else {
const MAX_ARRAY_CAPACITY: usize = 1024 * 1024; // 1M elements max
if full_size > MAX_ARRAY_CAPACITY {
return Err(anyhow::anyhow!("array capacity too large: {}", full_size));
}
stack.push(Frame::Array {
collected: Vec::with_capacity(full_size),
remaining: full_size,
Expand Down
5 changes: 5 additions & 0 deletions executor/src/wasi/genlayer_sdk.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1301,6 +1301,11 @@ impl ContextVFS<'_> {
}
Some(data) => {
use crate::public_abi::ResultCode;
if data.is_empty() {
return Err(generated::types::Error::trap(
crate::anyhow_to_wasmtime(anyhow::anyhow!("leader nondet result is empty"))
));
}
let rest = &data[1..];
let res = match data[0] {
x if x == ResultCode::Return as u8 => rt::vm::RunOk::Return(rest.into()),
Expand Down
Loading