fix(gltest): resolve runners from local tree when GENVM_PREBUILT_DIR set#98
Open
kp2pml30 wants to merge 4 commits into
Open
fix(gltest): resolve runners from local tree when GENVM_PREBUILT_DIR set#98kp2pml30 wants to merge 4 commits into
kp2pml30 wants to merge 4 commits into
Conversation
GenVM v0.6 dropped the monolithic runner bundle the direct/glsim loader downloads from the (retired) genlayerlabs/genvm releases, so under v0.6 every load failed with `No GenVM runner bundle for <version>`. When GENVM_PREBUILT_DIR points at a prebuilt GenVM tree, extract the runner straight from its content-addressed tar (globbed under any *runners* dir, so runners/ and executor/<ver>/legacy-runners/ both resolve) and skip the download. Download path is untouched and stays the default when the env var is unset.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Jul 9, 2026
The gltest/glsim test fixtures still used old-idiom markers that break under GenVM v0.6: gl.DynArray/TreeMap -> gl.storage.*, gl.Contract -> gl.contract.Contract, and callable gl.u256(x) -> plain x. Migrate all fixtures under tests/ (examples/, glsim/, gltest/artifact/); Depends/runner-hash header lines are untouched. Package source (gltest/, glsim/) is not changed.
The genvm release bundle moved from the retired genlayerlabs/genvm repo to genlayerlabs/genvm-manager. Update both the download and release-discovery URLs so the sdk_loader download fallback resolves against the live repo.
genvm-manager v0.6 ships a per-platform whole-tree tarball (genvm-<arch>-<os>.tar.xz) instead of the retired runner-only bundle, so the download fallback now selects the host asset and unpacks the whole tree once (atomically, cached) into a GENVM_PREBUILT_DIR-shaped dir, then resolves runners through the same glob path as the prebuilt tree. This collapses the download and prebuilt paths onto one extraction routine and handles both the current runners/ and the legacy-runners/ overlay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GenVM v0.6 dropped the monolithic runner bundle that
gltest.direct/glsimdownload from the (retired)genlayerlabs/genvmreleases, so under v0.6 every SDK load failed withNo GenVM runner bundle for <version>— breaking the in-process glsim RPC-compat suite (every deploy) in the v0.6 e2e track.When
GENVM_PREBUILT_DIRpoints at a prebuilt GenVM tree, resolve the runner straight from its content-addressed tar (globbed under any*runners*dir, so bothrunners/andexecutor/<ver>/legacy-runners/resolve) and skip the download. The download path is untouched and stays the default when the env var is unset — backwards compatible for existing usage.Pairs with the
genlayer-e2ewiring that exportsGENVM_PREBUILT_DIRinto the glsim test step.Part of the genvm-manager v0.6 migration changeset
Depends-On: genlayerlabs/genvm-manager#1
Depends-On: https://github.com/genlayerlabs/genlayer-node/pull/1502
Depends-On: https://github.com/genlayerlabs/genlayer-dev-env/pull/95
Depends-On: https://github.com/genlayerlabs/genlayer-e2e/pull/619
Depends-On: genlayerlabs/genlayer-studio#1697
Depends-On: genlayerlabs/genlayer-py#96
Depends-On: genlayerlabs/genlayer-js#192
Depends-On: #98