Skip to content

[codex] send health metrics on wall-clock cadence#1695

Draft
MuncleUscles wants to merge 1 commit into
v0.123-devfrom
codex/fix-health-metrics-cadence
Draft

[codex] send health metrics on wall-clock cadence#1695
MuncleUscles wants to merge 1 commit into
v0.123-devfrom
codex/fix-health-metrics-cadence

Conversation

@MuncleUscles

Copy link
Copy Markdown
Member

Summary

  • send system health metrics on a wall-clock cadence instead of every sixth health-check loop
  • send the first metrics update as soon as the health loop has a cache to report
  • add a regression test for the wall-clock cadence helper

Why

Rally Testnet hit NOT REPORTING alerts while /health was reachable. The health loop was taking 15-20s under load, but metrics reporting was tied to loop count (6 * loop) instead of elapsed time. That can stretch the intended one-minute reporting cadence past the external stale threshold.

This keeps health reporting cadence stable even when individual health checks are slow.

Validation

  • /Users/edgars/Dev/genlayer-studio/.venv/bin/python -m pytest tests/unit/test_rpc_health_genvm_tracking.py

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f5b5f423-c8d1-44df-89e4-14edf1afa43b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-health-metrics-cadence

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot changed the base branch from main to v0.123-dev June 25, 2026 19:00
@github-actions

Copy link
Copy Markdown
Contributor

This PR targeted main, which is only the default/static branch.

I retargeted it to v0.123-dev, the active development branch. Pushes to v0.123-dev automatically fast-forward main.

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
11 Security Hotspots
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant