Repository navigation
docs: add paper FDTD examples and solver benchmark - #517
Conversation
github-actions
Bot
added
documentation
503181e to
3e0eef5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #517 +/- ##
=======================================
Coverage 91.62% 91.62%
=======================================
Files 204 204
Lines 28260 28260
Branches 5345 5345
=======================================
Hits 25894 25894
Misses 1354 1354
Partials 1012 1012 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3e0eef5cfc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if any( | ||
| isinstance(node, ast.Call) | ||
| and isinstance(node.func, ast.Attribute) | ||
| and node.func.attr in {"plot_2d", "plot_3d"} | ||
| for node in ast.walk(tree) | ||
| ): | ||
| break |
There was a problem hiding this comment.
When a maintainer changes geometry, materials, domain settings, or another model property in a cell after the first plot_2d/plot_3d call—or earlier in that same cell—the loop stops before hashing the change. Because reference_run only separately checks cell size and center wavelength, docs CI can accept and publish S-parameters from the old model under the modified notebook. Continue scanning model-affecting statements or fingerprint the resolved simulation configuration instead.
AGENTS.md reference: AGENTS.md:L56-L59
Useful? React with 👍 / 👎.
Adds four FDTD paper examples and a directional-coupler benchmark page with transmission spectra, field views, throughput, scalability, and cost charts.