Use REST API to add tables in system tests - #7954
Open
zhangxinyao88 wants to merge 10 commits into
Open
Conversation
zhangxinyao88
marked this pull request as ready for review
August 21, 2026 13:00
patchwork01
reviewed
Aug 21, 2026
Collaborator
There was a problem hiding this comment.
Thanks very much, this looks good. We'll need to test this in AWS ourselves before we can approve/merge it. Have you been able to do that yourself?
It should be enough just to run SetupInstanceST. There's some documentation for running system tests here:
https://github.com/gchq/sleeper/blob/develop/docs/development/system-tests.md#acceptance-tests
That has some costs associated with it so we'll understand if you'd rather leave it to us.
Contributor
Author
|
I haven't run SetupInstanceST in AWS, so I'm happy to leave that one with you. The focused WireMock and LocalStack tests pass locally, as does the Java reactor build. |
patchwork01
approved these changes
Aug 25, 2026
patchwork01
added
the
needs-reviewer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7347.
AwsSleeperTablesDriver.addTablenow sends a SigV4-signed request toPOST /sleeper/tables. The add-table test runs against WireMock, while the remaining LocalStack test uses a test-only driver because LocalStack has no API Gateway support.Testing:
AwsSleeperTablesDriverWiremockITAwsSleeperTablesDriverIT-DskipRust=true)