fix: keep root gstack skill loadable in codex#334
Open
malikrohail wants to merge 1 commit intogarrytan:mainfrom
Open
fix: keep root gstack skill loadable in codex#334malikrohail wants to merge 1 commit intogarrytan:mainfrom
malikrohail wants to merge 1 commit intogarrytan:mainfrom
Conversation
Author
|
@garrytan tested on March 22, 2026 with This is intentionally the smallest fix I could verify end-to-end:
Before this patch, Codex emitted the root-skill load error during a real I also checked PR #326 while narrowing this down. It does not touch the root |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gstackskill description under Codex CLI's current 1024-character frontmatter limitSKILL.mdand.agents/skills/gstack/SKILL.mdWhy this PR
On March 22, 2026, I tested current
mainwithcodex-cli 0.116.0and reproduced a live Codex compatibility error:I also saw the same root-skill failure for:
I could not reproduce the symlink-specific claim from issue #333 on current
main, but this root-skill frontmatter failure is a confirmed Codex loading bug on the current codepath.PR #326 does not address this area. It does not touch the root
gstackskill frontmatter or Codex root-skill loading.Related to #333.
Verification
bun testbun test test/gen-skill-docs.test.ts./setup --host codexcodex exec --ephemeral -C /Users/test/.codex/skills/gstack -s read-only -o /tmp/gstack-codex-skills-after.txt "List any installed skills you have available. Return only names, comma-separated."Result
Before this change, Codex emitted the root
gstackinvalid descriptionerror.After this change:
gstackappears in the installed skill listgstackinvalid description: exceeds maximum length of 1024 characterserror is gone