Conversation
chryzsh
force-pushed
the
fix/relay-attack-completion-logic
branch
from
September 1, 2026 16:49
4d747ce to
a0e92fe
Compare
chryzsh
force-pushed
the
fix/relay-attack-completion-logic
branch
from
September 1, 2026 16:49
a0e92fe to
17531e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In attacks/relay.py
SUCCESSwas set on every outcome (success, 401, unexpected status, exception), causing the listener to hard-exit after the first attempt regardless of result.Separately,
_sendAuthalways returned aNoneinstead of the(response, errorCode)tuple impacket's relay framework expects, crashing with aTypeErroron every relayed auth.I wrote tests to verify the bug, and made all the tests pass.
Also, unrelated to the above, the
to/timeoutflag was dead in the main loop, so added the code that actually implements the timeout. Set the default timeout to 5 minutes / 300 seconds.After I had done this, I wondered: was this relay code that implements TAKEOVER-5 just something you made pending the merge request to ntlmrelayx for supporting relaying to the adminservice api? Because i got started with looking at some bugs and then I realized maybe this is dead code you dont plan to have. Decided to submit this anyway since I did it mostly to learn more Python, so just do what you want with this PR.