[stertooy]

Closes #280.

I decided to err on the side of caution and replace it with AddToIgs whenever I felt unsure that the call was safe.

Also replaced some SubgroupByIgs( ..., AddIgsToIgs( ..., ... ) ) calls with SubgroupByIgsAndIgs( ..., ..., ...), because that's what it was made for after all.

Note: one test will fail, because it's affected by a separate bug. I'm working on that, but I didn't want to omit a valid regression test.

[stertooy]

I think the tests will pass after #283 is merged.

[fingolfin]

Should go in after #283: the remaining CI failure (tst/AddIgsToIgs.tst:17) is #282, which #283 fixes. With both merged onto master, testall passes, including with all POLYCYCLIC_CHECK_* flags.

[codecov]

Codecov Report

❌ Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.51%. Comparing base (1a1bd0e) to head (2f3cf6c).

Files with missing lines	Patch %	Lines
gap/basic/pcpsers.gi	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
- Coverage   71.52%   71.51%   -0.01%     
==========================================
  Files          88       88              
  Lines       13032    13029       -3     
==========================================
- Hits         9321     9318       -3     
  Misses       3711     3711              

Files with missing lines	Coverage Δ
gap/action/orbnorm.gi	81.51% <100.00%> (ø)
gap/action/orbstab.gi	96.83% <100.00%> (ø)
gap/cohom/grpcom.gi	78.89% <100.00%> (ø)
gap/pcpgrp/centcon.gi	97.38% <100.00%> (-0.03%)	⬇️
gap/pcpgrp/findex.gi	97.25% <100.00%> (ø)
gap/pcpgrp/fitting.gi	83.21% <100.00%> (ø)
gap/pcpgrp/maxsub.gi	100.00% <100.00%> (+2.04%)	⬆️
gap/pcpgrp/normcon.gi	93.10% <100.00%> (-0.04%)	⬇️
gap/pcpgrp/torsion.gi	86.57% <100.00%> (ø)
gap/basic/pcpsers.gi	75.08% <66.66%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.