Repository navigation
AddToIgs improvements 5: use smaller exponents when norming & sifting - #241
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #241 +/- ##
==========================================
+ Coverage 69.64% 69.65% +0.01%
==========================================
Files 88 88
Lines 12899 12907 +8
==========================================
+ Hits 8983 8991 +8
Misses 3916 3916
🚀 New features to boost your workflow:
|
stertooy
force-pushed
the
igs-improv-5
branch
from
October 17, 2026 11:29
30d34d2 to
b27e81b
Compare
stertooy
marked this pull request as ready for review
October 17, 2026 11:29
fingolfin
reviewed
Oct 17, 2026
| <Description> | ||
| returns an integer <M>e</M>, either positive or <M>-1</M>, such that the pcp-element | ||
| <A>g</A> raised to the power of <M>e</M> is normed. | ||
| returns an integer <M>e</M> such that the pcp-element <A>g</A> raised to the |
Member
There was a problem hiding this comment.
This changes documented results: NormingExponent can now be negative at finite depths, and NormedPcpElement, Ngs, Igs return different elements. E.g. G := PcGroupToPcpGroup(CyclicGroup(IsPcGroup, 25));; NormingExponent(G.1^2); gives 3 on master, -2 here; NormedPcpElement(G.1^2) gives g1*g2 vs g1*g2^4. #174 had a CHANGES.md entry for this; please carry it over. Optionally state the range here: in (-r/2, r/2] for relative order r > 0, ±1 for r = 0.
Choose residues in (-r/2, r/2] at finite depths. Assisted-by: Claude Code (Fable 5.1)
stertooy
force-pushed
the
igs-improv-5
branch
from
October 17, 2026 11:50
b27e81b to
43db182
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #174, builds upon #236 and #240. I'll mark this a draft PR until those are merged and this has been rebased.
This PR introduces the$\left(-\frac{r}{2},\frac{r}{2}\right]$ than in $[0,r)$ . This approximately halves the average exponent, which leads to less/easier calculations.
SmallestResidueapproach from #174. The idea is quite simple: if we're on a finite layer with relative exponentr, it's better to consider exponents inOriginal PR disclaimer:
Assisted-by: Claude Code (Fable 5.1)