Skip to content

Fix incorrect index checking in RectArray<T>::SwitchRows #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tturocy merged 1 commit into from
May 27, 2026
Merged

Fix incorrect index checking in RectArray<T>::SwitchRows #891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
- Corrected resizing of row and column index labels in strategic form so pivoting works correctly. (#844)
- Corrected incorrect output of strategic game tables to .nfg files if strategies have previously been
deleted in the game (#875)
- Fix incorrect row index checking in swapping rows of a rectangular array (leading to errors in
for example `simpdiv_solve`) (#868)


### Removed
- Built-in plotting of logit QRE for strategic games has been removed in the GUI (#809)
Expand Down
2 changes: 1 addition & 1 deletion src/core/recarray.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ template <class T> class RectArray {
//@{
void SwitchRows(int i, int j)
{
if (!Check(i, j)) {
if (!CheckRow(i) || !CheckRow(j)) {
throw std::out_of_range("Index out of range in RectArray");
}
if (i == j) {
Expand Down
Loading