Issue 517: adding GameRep::GetPlays for Node, Infoset, and Action; exposing it to Cython#521
Closed
d-kad wants to merge 11 commits into
Closed
Issue 517: adding GameRep::GetPlays for Node, Infoset, and Action; exposing it to Cython#521d-kad wants to merge 11 commits into
GameRep::GetPlays for Node, Infoset, and Action; exposing it to Cython#521d-kad wants to merge 11 commits into
Conversation
tturocy
requested changes
May 15, 2025
tturocy
requested changes
May 19, 2025
tturocy
left a comment
tturocy
left a comment
Member
There was a problem hiding this comment.
When we're adding/changing something public, we should also have the following:
- Appropriate entry in ChangeLog
- Add function to the documentation index (
doc/pygambit.api.rst) in appropriate location - Consider adding a user guide section (
doc/pygambit.user.rst) which illustrates the use/usefulness of the functions.
… a docstring for Game.get_plays method
….get_plays method; correct tests and documentation
Member
|
Merged at 7df3d34. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently work in progress:
@tturocy I tried to extend
Game.get_playsto cover the cases of Infoset and Action.This Cython code does not compile after introducing new
GetPlaysoverloads.When there is a single overload for Node alone in commit b767236, it compiles.
Could you please help?