Skip to content

Creating satellite mass bound initializor class and migrations#1074

Open
Copilot wants to merge 4 commits intomasterfrom
copilot/add-satellite-mass-bound-initializor
Open

Creating satellite mass bound initializor class and migrations#1074
Copilot wants to merge 4 commits intomasterfrom
copilot/add-satellite-mass-bound-initializor

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 14, 2026 •
edited by abensonca
Loading

Moves the logic for initialization of subhalo bound masses to a new satelliteMassBoundInitializor class. This allows for more flexibility than having a few, enumerated options for initialization in the orbiting satellite component.

Copilot AI and others added 3 commits April 11, 2026 19:13
@abensonca
Add satelliteMassBoundInitializor functionClass and update migrations
212e406 
Agent-Logs-Url: https://github.com/galacticusorg/galacticus/sessions/203a4502-8f55-42b6-a5f9-b11ff1becef3

Co-authored-by: abensonca <7468651+abensonca@users.noreply.github.com>
@abensonca
fix: Minor clean up for coding conventions
6171134 
Rename files for consistency with conventions. Remove an empty constructor. Rename some variables for consistency with conventions.
@abensonca
fix: Update all parameter files for recent changes in satellite bound…
f7112e3 
… mass initialization parameters
@abensonca abensonca added subhalos satellites Relating to properties and physics of satellite halos/galaxies labels Apr 14, 2026
@abensonca abensonca linked an issue Apr 14, 2026 that may be closed by this pull request
Initialization of subhalo bound mass should be done via a class instead of a parameter switch #1006
Open
@abensonca abensonca marked this pull request as ready for review April 14, 2026 18:20
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 15, 2026

Embedded XML/LaTeX warnings (click to expand)

⚠️ Possible misspelled word 'initializor' in file 'source/satellites.bound_mass.initialize.basic_mass.F90'
⚠️ Possible misspelled word 'initializor' in file 'source/satellites.bound_mass.initialize.basic_mass.F90'
⚠️ Possible misspelled word 'initializor' in file 'source/satellites.bound_mass.initialize.basic_mass.F90'
⚠️ Possible misspelled word 'initializor' in file 'source/satellites.bound_mass.initialize.basic_mass.F90'
⚠️ Possible misspelled word 'initializor' in file 'source/satellites.bound_mass.initialize.basic_mass.F90'
⚠️ Possible misspelled word 'initializor' in file 'source/satellites.bound_mass.initialize.density_contrast.F90'
⚠️ Possible misspelled word 'initializor' in file 'source/satellites.bound_mass.initialize.density_contrast.F90'
⚠️ Possible misspelled word 'initializor' in file 'source/satellites.bound_mass.initialize.density_contrast.F90'
⚠️ Possible misspelled word 'initializor' in file 'source/satellites.bound_mass.initialize.density_contrast.F90'
⚠️ Possible misspelled word 'initializor' in file 'source/satellites.bound_mass.initialize.density_contrast.F90'
⚠️ Possible misspelled word 'initializor' in file 'source/satellites.bound_mass.initialize.density_contrast.F90'
⚠️ Possible misspelled word 'initializor' in file 'source/satellites.bound_mass.initialize.density_contrast.F90'
⚠️ Possible misspelled word 'initializor' in file 'source/satellites.bound_mass.initialize.maximum_radius.F90'
⚠️ Possible misspelled word 'initializor' in file 'source/satellites.bound_mass.initialize.maximum_radius.F90'
⚠️ Possible misspelled word 'initializor' in file 'source/satellites.bound_mass.initialize.maximum_radius.F90'
⚠️ Possible misspelled word 'initializor' in file 'source/satellites.bound_mass.initialize.maximum_radius.F90'
⚠️ Possible misspelled word 'initializor' in file 'source/satellites.bound_mass.initialize.maximum_radius.F90'
⚠️ Possible misspelled word 'initializor' in file 'source/satellites.bound_mass.initialize.maximum_radius.F90'
⚠️ Possible misspelled word 'initializor' in file 'source/satellites.bound_mass.initialize.maximum_radius.F90'

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 15, 2026

Embedded XML/LaTeX warnings (click to expand)

⚠️ Possible misspelled word 'initializor' in file 'source/satellites.bound_mass.initialize.basic_mass.F90'
⚠️ Possible misspelled word 'initializor' in file 'source/satellites.bound_mass.initialize.basic_mass.F90'
⚠️ Possible misspelled word 'initializor' in file 'source/satellites.bound_mass.initialize.basic_mass.F90'
⚠️ Possible misspelled word 'initializor' in file 'source/satellites.bound_mass.initialize.basic_mass.F90'
⚠️ Possible misspelled word 'initializor' in file 'source/satellites.bound_mass.initialize.basic_mass.F90'
⚠️ Possible misspelled word 'initializor' in file 'source/satellites.bound_mass.initialize.density_contrast.F90'
⚠️ Possible misspelled word 'initializor' in file 'source/satellites.bound_mass.initialize.density_contrast.F90'
⚠️ Possible misspelled word 'initializor' in file 'source/satellites.bound_mass.initialize.density_contrast.F90'
⚠️ Possible misspelled word 'initializor' in file 'source/satellites.bound_mass.initialize.density_contrast.F90'
⚠️ Possible misspelled word 'initializor' in file 'source/satellites.bound_mass.initialize.density_contrast.F90'
⚠️ Possible misspelled word 'initializor' in file 'source/satellites.bound_mass.initialize.density_contrast.F90'
⚠️ Possible misspelled word 'initializor' in file 'source/satellites.bound_mass.initialize.density_contrast.F90'
⚠️ Possible misspelled word 'initializor' in file 'source/satellites.bound_mass.initialize.maximum_radius.F90'
⚠️ Possible misspelled word 'initializor' in file 'source/satellites.bound_mass.initialize.maximum_radius.F90'
⚠️ Possible misspelled word 'initializor' in file 'source/satellites.bound_mass.initialize.maximum_radius.F90'
⚠️ Possible misspelled word 'initializor' in file 'source/satellites.bound_mass.initialize.maximum_radius.F90'
⚠️ Possible misspelled word 'initializor' in file 'source/satellites.bound_mass.initialize.maximum_radius.F90'
⚠️ Possible misspelled word 'initializor' in file 'source/satellites.bound_mass.initialize.maximum_radius.F90'
⚠️ Possible misspelled word 'initializor' in file 'source/satellites.bound_mass.initialize.maximum_radius.F90'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@abensonca abensonca

Copilot code review Copilot

Labels

satellites Relating to properties and physics of satellite halos/galaxies subhalos

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Initialization of subhalo bound mass should be done via a class instead of a parameter switch

2 participants

@abensonca