Add Codex parity pass for shortcuts, thread find, and focus guards#63
Open
Add Codex parity pass for shortcuts, thread find, and focus guards#63
Conversation
This bundles parity-focused UX and shortcut behavior updates across app shell, composer, and thread surfaces, plus expanded manual validation docs. The goal is consistent desktop-like keybinding behavior, safer focus guards, and discoverable in-thread search ergonomics. Constraint: Keep existing UI architecture and avoid adding new dependencies Rejected: Introduce a dedicated command palette modal | out of scope for parity patch Rejected: Split into many tiny commits | requested as one PR-ready feature bundle Confidence: medium Scope-risk: moderate Reversibility: clean Directive: Keep shortcut guards aligned across editable and terminal-focus checks before adding new accelerators Tested: Targeted Playwright shortcut assertions and parity report runs during implementation Not-tested: Full deterministic end-to-end pass across all parity scripts in a clean, single-server session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR completes a broad Codex desktop parity pass for keyboard-first workflows in the web app. The main objective is to make global shortcuts predictable, route-safe, and focus-safe while adding thread-scoped find behavior that matches expected desktop ergonomics.
What Changed
1) Thread-Scoped Find UX (new)
Implemented a dedicated
Find in threadcontrol set in the thread header actions area:Find in thread)current/total)Behavior added:
EnterandShift+Enterstep through matchesImplementation wiring:
2) Global Shortcut Parity Expansion
Extended and normalized shortcut handling in app shell to align with Codex-style desktop flows, including fallback mappings where this fork lacks exact panel equivalents.
Covered areas include:
3) Focus-Safety Guards (major hardening)
Added consistent safety guards so global shortcuts do not fire when user focus is in:
input,textarea,contenteditable, select-like/combobox/search/spinbutton surfaces)[data-codex-terminal]and related probes)Result:
4) Composer Keyboard/Escape Parity
Refined composer key handling paths for parity and consistency:
5) Sidebar Thread Tree Integration
Added integration points for keyboard-driven thread actions from shell-level shortcuts:
6) Account/Label/Formatting Parity Polish
Small but user-visible parity improvements:
7) Parity Knowledge Base Updates
Updated
.agents/skills/codex-app-parity/SKILL.mdwith concrete findings from this implementation cycle:8) Manual Verification Coverage Expansion
tests.mdnow includes extensive feature-by-feature manual test sections with:Changed Files
.agents/skills/codex-app-parity/SKILL.md.gitignoresrc/App.vuesrc/components/content/ThreadComposer.vuesrc/components/content/ThreadConversation.vuesrc/components/sidebar/SidebarThreadTree.vuesrc/composables/useDesktopState.tstests.mdVerification Performed
Notes:
Risk Assessment
tests.mdBackward Compatibility
Follow-up Candidates (optional)