Cleanup power formula tests #1353
Merged
+10
−224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Formula generation and evaluation are implemented separately and tested elsewhere. So here we only need to test that the formulas apply the correct formula. Signed-off-by: Sahas Subramanian <[email protected]>
Formula generation and evaluation are implemented separately and tested elsewhere. So here we only need to test that the formulas apply the correct formula. Signed-off-by: Sahas Subramanian <[email protected]>
Formula generation and evaluation are implemented separately and tested elsewhere. So here we only need to test that the formulas apply the correct formula. Signed-off-by: Sahas Subramanian <[email protected]>
These tests should ideally use custom formulas and not depend on the formula generator, but that's a bigger change because that would affect most of the tests in this repo. Signed-off-by: Sahas Subramanian <[email protected]>
Signed-off-by: Sahas Subramanian <[email protected]>
shsms
requested review from
ela-kotulska-frequenz
and removed request for
a team
github-actions
bot
added
part:tests
llucax
reviewed
Feb 10, 2026
Contributor
llucax
left a comment
llucax
left a comment
There was a problem hiding this comment.
LGTM, but I think we probably make more noise about the version bump.
RELEASE_NOTES.md
Outdated
| ## Upgrading | ||
|
|
||
| <!-- Here goes notes on how to upgrade from previous versions, including deprecations and what they should be replaced with --> | ||
| - The minimum required version of `frequenz-microgrid-component-graph` is now `0.3.4`. |
Contributor
There was a problem hiding this comment.
Maybe copy the release notes of 0.3.4 or at least give a link to them and make it more prominent that there were some behavioral changes in that release?
Signed-off-by: Sahas Subramanian <[email protected]>
Contributor
Author
It's not such a big deal because this has been the only behaviour that's ever been in production. The early versions of the rust component graph made two changes - one turned out to be a perf issue, the other one wasn't usable until operation modes are available, so they are both back to old SDK behaviour. But I've updated the release notes anyway. |
llucax
approved these changes
Feb 12, 2026
github-project-automation
bot
moved this from To do
to Review approved
in Python SDK Roadmap
github-project-automation
bot
moved this from Review approved
to Done
in Python SDK Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generation and evaluation of the formulas are now implemented and tested separately. So here we only need to test we are calling the correct formulas.