Repository navigation
Render occurrences reported without a backtrace - #103
Merged
Merged
Conversation
Rails 7 reports an exception that was never raised with a nil backtrace, and the error page and email both called split on it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Rails 7.1 and 7.2,
Rails.error.report(SomeError.new("…"))with an exception that was never raised stores an occurrence whosebacktraceisnil. Rails 8 fills one in.Occurrence#parsed_backtracecallsbacktrace.split, so the error page and the error email both raiseNoMethodErrorfor that occurrence.Backtrace.parsealready treatsnilas an empty list, so the fix isbacktrace&.split. The new request test sets an occurrence's backtrace toniland loads the error page. It fails without the fix on both Rails 7.1 and 8.1.🤖 Generated with Claude Code