Repository navigation
Fix error email rendering after the style nonce change - #102
Merged
Merged
Conversation
The error email renders the same style partial as the dashboard layout, and mailer views have no content_security_policy_nonce, so every error email raised while rendering. The layout now passes the nonce in as a local. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ls 7 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#92 added
nonce="<%= content_security_policy_nonce %>"to the shared style partial. The error email renders that same partial, and mailer views have nocontent_security_policy_nonce, so every error email onmainnow raisesActionView::Template::Error. This hasn't been released.The dashboard layout now passes the nonce in as a local, and the partial adds the attribute only when it gets one. The new mailer test renders the email and fails on current
main. The CSP nonce test from #92 still passes.🤖 Generated with Claude Code