[#5559] Add activity behavior for Apply Active Effect behavior#6798
Open
arbron wants to merge 1 commit into
Open
[#5559] Add activity behavior for Apply Active Effect behavior#6798arbron wants to merge 1 commit into
arbron wants to merge 1 commit into
Conversation
arbron
force-pushed
the
activity/behaviors
branch
from
0dae221 to
454bb9e
Compare
Adds a new activity behavior that creates core's Apply Active Effect Region Behavior.
arbron
force-pushed
the
activity/behavior-apply-ae
branch
from
ae9ba6b to
582ee90
Compare
Fyorl
requested changes
Jun 19, 2026
| createBehaviorData(activity, options={}) { | ||
| return { | ||
| system: { | ||
| effects: this.effects |
Contributor
There was a problem hiding this comment.
DifficultTerrainActivityBehavior uses Array.from(this.types) on its own SetField. Should they be consistent? Or are they only cosmetically similar?
| * @enum {ActivityBehaviorConfiguration} | ||
| */ | ||
| DND5E.activityBehaviorTypes = { | ||
| appylActiveEffect: { |
Contributor
There was a problem hiding this comment.
Suggested change
| appylActiveEffect: { | |
| applyActiveEffect: { |
| */ | ||
|
|
||
| /** | ||
| * Data model representing the difficult terrain activity behavior configuration. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Data model representing the difficult terrain activity behavior configuration. | |
| * Data model representing the active effect activity behavior configuration. |
| /** @override */ | ||
| static defineSchema() { | ||
| return { | ||
| effects: new SetField(new DocumentUUIDField()) |
Contributor
There was a problem hiding this comment.
Suggested change
| effects: new SetField(new DocumentUUIDField()) | |
| effects: new SetField(new DocumentUUIDField({ type: "ActiveEffect", nullable: false })) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new activity behavior that creates core's Apply Active Effect Region Behavior.