fix: resolved zip-slip vulnerability (W-23558165) - #1812
Merged
Conversation
WillieRuemmele
approved these changes
Jul 31, 2026
| const fullDest = isAbsolute(path) | ||
| ? path | ||
| : join(this.defaultDirectory ?? component.getPackageRelativePath('', 'source'), path); | ||
| const baseDestinationPath = isAbsolute(baseContentPath) |
Member
There was a problem hiding this comment.
NIT: this could be hoisted out of the loop for performance
Member
QA Notes✅ : Jamie recorded a video of it working, too large to attach in GH |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Today, a malicious static resource could use a zip-slip attack to seize control of a user's machine when the resource is retrieved and unpacked. This PR closes that security gap.
What issues does this PR fix or reference?
@W-23558165@
Functionality Before
Unpacking a malicious resource could lead to a file getting dropped into, e.g., the user's startup folder, taking over the machine the next time they reboot.
Functionality After
A static resource attempting a zip-slip attack is detected, and the retrieval fails with a message about how the resource attempted to extract a file outside of its extraction directory.
Metadata Registry: Successful Deploy and Retrieve (required if applicable)
N/A
Deploy output:
N/A
Retrieve output:
N/A