Feature: Highlighter that works on PDFs#1602
Conversation
…prevent alpha accumulation Co-authored-by: Keschler <62390998+Keschler@users.noreply.github.com>
Co-authored-by: Keschler <62390998+Keschler@users.noreply.github.com>
…direction Co-authored-by: Keschler <62390998+Keschler@users.noreply.github.com>
…e regeneration Co-authored-by: Keschler <62390998+Keschler@users.noreply.github.com>
|
I just realized a similar highlighter exists #1210, but my implementation still seems useful, because it is easier to find and usable as a pen instead of a shape. An useful addition could be to modify the transparency/opacity |
|
I agree. Although the shape is nice, the pen is what I'm most likely to use. Is the Auto-Straighten feature for all pens, or just for the highlighter? |
|
Just for the highlighter right now |
| self.brush_config.solid_options.stroke_color = Some(stroke_color); | ||
| self.brush_config.textured_options.stroke_color = Some(stroke_color); | ||
| let mut highlight_color = stroke_color; | ||
| highlight_color.a = 0.2; |
There was a problem hiding this comment.
instead of hardcoding this value, please put it into a descriptively named associated constant of PensConfig and use it here
|
@flxzt Is it now ready to get merged? |
|
I also have a branch with a highlighter and other features here: https://github.com/Xyndra/rnote/tree/highlighter that I have simply used for myself, maybe that could be interesting to look at. It would also be nice if you could send a screenshot of how it looks when things overlap, either in the same or multiple strokes |
|
Does this lock onto text automatically if the pdf encoding allows that? |
|
No, not yet |
|
hi, i would like to use your addon. I missing a Highlighter since switching from GoodNotes to Rnote. The Problem is, my Knowledge about Rust is close 2 zero. Would you be so kind to help me, install your addon? |
|
What is the difference between the added As far as I can tell, the EDIT: I've created #1729 with a fix for transparent strokes, and #1730 that makes strokes with the existing Highlighter/Marker multiplicative. |
I think the highlighter as pen fixed the transparency than brushes, For me, fixed the transparency on brushes can make easier than custom something |
|
yeah I would strongly prefer a seperate highlighter tool, otherwise it's terrible UX |
|
terrible UX
^^^^
Yeah highlighting and notes are 90% of my workflow. Having a separate tool
is very important imo
…On Sun, Apr 12, 2026 at 12:25 PM Xyndra ***@***.***> wrote:
*Xyndra* left a comment (flxzt/rnote#1602)
<#1602 (comment)>
yeah I would strongly prefer a seperate highlighter tool, otherwise it's
terrible UX
—
Reply to this email directly, view it on GitHub
<#1602 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3QHV6MVWXSKSULLZVRMQXL4VPURPAVCNFSM6AAAAACNOWUSVWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DEMZSGU3DOMZYGE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
I disagree, the semantic difference is not that large (assuming that you mean a tool in the bottom bar). Most of the UI in the sidebar would be exactly the same. I would simply expand the brush style menu into linked EDIT: It could look something like this. 
Splitting up the highlighter and regular brush styles could make sense if we had more than three... But even then, we could simply use a separator in the sidebar. |
|
I implore you to take a look at my fork where I also have a highlighter tool in a branch |
|
I did take a look, and I'm not really convinced. In terms of input (and concept), the highlighter fits very well into the existing brush tool. In your branch, the UI elements in the sidebar of the highlighter and brush are pretty much identical. The only advantage of a separate tool that I can think of is that you can register a shortcut for it. And I guess you'd need marginally less time when you have to switch both the tool and the brush style. In my opinion, both things currently don't justify duplicating the UI |
|
It isn't about the timing, it's about me wanting to have different sizes for my highlighter, wanting some options about transparency and corner shapes, wanting some other colors and generally highlighters and pens are in fact not used for the same stuff. A pen is for thin lines, a marker is for large areas. If you look at any other drawing application, they all also have them separate, because for that reasoning you could just as well have the eraser be part of the pen as well |
You can, the size is already tied to the brush style.
There is already a configuration menu with options specific to the brush style. It even has the same position as the one in your branch :P
The difference between highlighters and other brush styles is certainly not as big as between the other tools. Besides that, wouldn't a very similar reasoning also apply to the textured brush style? In my opinion, the similarities significantly outweigh the differences, but I've already explained why I think so in my previous comments. |
|
@Keschler This brush have something issue when my computer render this line (Something slowly, and sometimes rnote crash when I use that) Screencast.From.2026-04-17.23-38-31.mp4 |
Creates a new type of brush: Highlighter
Addresses: #449
I added a new Highlighter brush designed for highlighting text on PDFs or notes. It features a pipeline to handle transparency correctly and includes an auto-straightening helper for cleaner lines.
Technical Implementation:
To fix Alpha-Accumulation
Demo:
Disclaimer: This implementation was primarily generated with the assistance of GitHub Copilot.