Decoupling recopy

[justinmc]

A recreate of #11669 by recopying all flutter/flutter stuff from scratch, and cherry picking all of my subsequent commits.

This is a single super mega PR attempting to migrate all Material and Cupertino code from flutter/flutter to material_ui and cupertino_ui.

How the PR was created

git filter-repo --path packages/flutter/lib/src/material --path packages/flutter/test/material --path examples/api/lib/material --path examples/api/test/material --path packages/flutter/lib/src/cupertino --path packages/flutter/test/cupertino --path examples/api/lib/cupertino --path examples/api/test/cupertino --path packages/flutter/lib/fix_data/fix_material --path packages/flutter/test_fixes/material --path packages/flutter/lib/fix_data/fix_cupertino.yaml --path packages/flutter/test_fixes/cupertino 
cd ../packages
git remote add source-origin ../flutter
git fetch source-origin
git merge source-origin/master --allow-unrelated-histories

I then cherry picked everything I could from the previous PR (#11669), skipping merge commits.

What was included in the copy

• The main source code (packages/flutter/lib/src/<material/cupertino>).
• The widget/unit tests (packages/flutter/test/<material/cupertino>).
• The examples (examples/api/lib/<material/cupertino>).
• The example tests (examples/api/test/<material/cupertino>).
• The dart fixes (packages/flutter/lib/fix_data).
• The dart fix tests (packages/flutter/test_fixes).

TODOs

• Do exports for Material and Cupertino.
• Confirm the directory structure (current plan: lib/src/ for now, reorganize after 1.0.0).
• Try installing and using the packages locally.
• Try running the tests locally (works except for tests with cross imports).
• Try running the example tests locally (work after migrating package:flutter_api_samples import).
• Verify examples work.
• Verify that git blame appears the same in both repos on various files. (Yes, but the SHAs are different, as expected.)
• Add auxiliary files for dart fixes and tests.
• Port imports of material/cupertino in places like examples/test to use the new packages.
• Fix Skip all test cross imports.
• Make sure the analyzer is working in the same exact way as it does in flutter/flutter. (Updated analysis_options line width from flutter/flutter #11692)

Open questions

• Are we sure about the directory structure?
  • Confirmed with @dkwingsmt and @QuncCccccc.
• Anything else that should be ported along with this? If these commits touch files that are not included in this PR, but that we later port in, the commits will likely have different SHAs.
  • I'm hoping we got it all at this point but if anyone notices anything let me know.
• Do we like the examples setup?
  • Worked with @stuartmorgan-g and @chunhtai to get this to match the other packages in this repo.
• Are we cool with skipping cross imports tests and fixing them later? This approach should not fracture commits because the commits were made in flutter/flutter after the code was copied.
  • Tests are in the temporarily_skipped_tests folder.

How to try using these packages

Add the local packages to your project:

flutter pub add cupertino_ui --path ../../packages/packages/cupertino_ui
flutter pub add material_ui --path ../../packages/packages/material_ui  

Then import the packages instead of the libraries in the SDK:

- import 'package:flutter/material.dart';
- import 'package:flutter/cupertino.dart';
+ import 'package:material_ui/material_ui.dart';
+ import 'package:cupertino_ui/cupertino_ui.dart';

How to review this PR

• Do read the PR description at the top, including Open Questions.
• Don't read all 600k+ lines changed! Ignore the main source code and test files. The only thing I changed in there is to change imports from flutter/material.dart to material_ui/material_ui.dart and the equivalent for Cupertino.
• Do look closely at the file tree browser on the left side of the "Files Changed" tab, though. Check the directory structure of material_ui and cupertino_ui and make sure it looks good to you.
• Do take a look at the small config files like pubspecs, analysis_options, etc.
• See the examples and their tests now located in material_ui/material_ui_examples and cupertino_ui/cupertino_ui_examples.
• See the data driven fixes in lib/fix_data and their tests in test_fixes.

And let me know if there is any code that's not in this PR that you expected to be. It will be best to get everything we can in this one PR rather than following up later in order to prevent fragmenting commits.

Resources

• Closed PR where i tried to import everything but forgot dart fixes.
  • Decoupling Material and Cupertino #11568
• Closed PR where I tried and failed to import a single widget by individually importing all of its transitive dependencies with git filter-repo commands.
  • Decoupling Material's ProgressIndicator #11526
• Closed PR where I tried to import just colors.dart (no dependencies), but found that it would create different SHAs between it and this mega PR.
  • Decoupling Material's colors.dart #11543
• Closed PR where I tried to import all of Material, before realizing that I would create different SHAs between that PR and a future Cupertino PR.
  • Decoupling Material #11549
• Closed main big PR with most of the history: Decoupling Material and Cupertino (with dart fixes) #11669
• Closed PR where I tried to cherry pick everything: Decoupling recreate #11887

[Piinks]

Ah this is so very close! Exciting! 🎊

[Piinks]

Should this be api?

[justinmc]

This is where I got it from: https://github.com/flutter/flutter/blob/master/examples/api/README.md

Looks like it indeed links to the api directory, but in our case it should say "example" instead!

[Piinks]

Nit: dartpad here could be (temporarily) misleading

[Piinks]

This is not the ultimate format based on the new @example dartdoc feature correct?

[justinmc]

Correct, I haven't changed any of the @tool dartpad directives yet. @dkwingsmt can you advise on what those should look like now?

I'll go ahead and change this one to @example for now and plan to migrate everything else after this PR lands.

[Piinks]

I don't think snippet or sample will be supported in these packages, we have to migrate them all to @example (not in this PR of course), and later we can add back @dartpad where it makes sense

[justinmc]

I'll remove this section.

[Piinks]

This one is dartpad in the snippet docs.

[justinmc]

Removed. Also I think we had this mistake live for a long time in https://github.com/flutter/flutter/blob/master/examples/api/README.md 😊

[Piinks]

Suggested change

	without crashing. Functionality tests are required the examples, and generally
	just do what is normally done for writing tests. The one thing that makes it
	more challenging to do for examples is that they can't really be written for
	testability in any obvious way, since that would complicate the examples and
	make them harder to explain.
	without crashing. Test coverage is required for examples, but should take care not to complicate the example strictly for the purpose of testing.

[Piinks]

This should not use flutter_goldens from flutter/flutter.

[Piinks]

This is flutter_goldens from flutter/flutter. It should use the implementation in flutter/packages

[Piinks]

Use right flutter_goldens

[Piinks]

Here and the rest, replace anys

[QuncCccccc]

The Material file structure LGTM.

Just for the record, we discussed that we don't want to move the old gen_defaults script to material_ui because we will no longer use the JSON tokens to generate default themes. We will have a new gen_default tool in material_ui generating defaults using Dart-defined tokens. The old gen_defaults tool is only used by Material, so we should gradually deprecate/remove it in dev/tools.

[justinmc]

@QuncCccccc Is there anything I need to change to set up for the new gen_default tool or get rid of stuff for the old script? All of the files with tokens generated by gen_defaults still have that section at the bottom.

[stuartmorgan-g]

The commit structure LG this time. I would recommend amending 4088b5e though, to make the first line more descriptive (e.g., "[cupertino_ui,material_ui] Post-import adjustments for new package-based structure"), and to make the body a real summary of what meaningfully changed rather than a raw log of incremental commit messages. (See a1bfadf for example.)

• Do we like the examples setup? Separate package at material_ui_examples that points to material_ui via the pubspec workspace. Similar to how flutter/flutter's flutter_api_samples works.

Is this part of the PR description obsolete? I just see the standard example/ subdir (which is what I would expect absent a strong reason to do something different).

• See the examples and their tests now located in material_ui/material_ui_examples and cupertino_ui/cupertino_ui_examples.

Same; this doesn't seem to match the current state.

[justinmc]

• ✅ Commit description updated.
• ✅ PR description "Open Questions" updated. I think we're good on these now but let me know if anyone still has anything to discuss.

[chunhtai]

the structure LGTM besides the open comments. There should be a main.dart in example which will be used by the pub dev. but that can wait until the first release

[chunhtai]

is this still needed that the repo is 100 width across?

[justinmc]

No, good catch!

[chunhtai]

same

[stuartmorgan-g]

Unless you've specifically set up workspaces at the package level, this should be removed.

[justinmc]

I did, I've got this line in both of the main pubspecs:

workspace:
  - example

This is how it was done in the main flutter/flutter repo. It seems useful especially since these example packages import their parent packages. But if there's a downside let me know.

[justinmc]

I don't want to do anything risky with this PR so if it's easier to just remove it and think about this later then I'm happy to do so.

[stuartmorgan-g]

I don't know of any downside offhand since I haven't really experimented with them yet. If it works, that's fine (we can alway remove it later if we find problems). I just wanted to make sure it wasn't accidental holdover from the mega-workspace in flutter/flutter.

[stuartmorgan-g]

Same here and anywhere else; we should remove any workspace entries unless you are deliberately configuring them. We currently don't use workspaces anywhere else in this repo (it's something that I plan to look into at some point, but haven't yet.)

[justinmc]

Discussion above at: #11888 (comment)

[justinmc]

the structure LGTM besides the open comments. There should be a main.dart in example which will be used by the pub dev. but that can wait until the first release

I've created an issue for the examples: flutter/flutter#187942

[QuncCccccc]

@QuncCccccc Is there anything I need to change to set up for the new gen_default tool or get rid of stuff for the old script? All of the files with tokens generated by gen_defaults still have that section at the bottom.

For new gen_default tool, nothing needed to change or setup ahead of time. We will later land this PR in material_ui.

For old script, nothing needed to get rid of in this PR. The defaults should be gradually migrated to use the new gen_defaults. But we should not remove anything for now.

[Piinks]

More than ever before, this