Fix test teardown method and remove redundant assertion#5
Merged
ochui merged 2 commits intotest/coveragefrom Jan 26, 2026
Merged
Fix test teardown method and remove redundant assertion#5ochui merged 2 commits intotest/coveragefrom
ochui merged 2 commits intotest/coveragefrom
Conversation
Co-authored-by: ochui <21917688+ochui@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Expand test coverage for FQ queueing system
Fix test teardown method and remove redundant assertion
Jan 26, 2026
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
There was a problem hiding this comment.
Pull request overview
Fixes async test teardown wiring so cleanup runs correctly, and removes a redundant assertion in edge case tests.
Changes:
- Renamed
test_asyncTearDowntoasyncTearDownsounittest.IsolatedAsyncioTestCaseruns teardown properly after each async test. - Removed a duplicate
assertTrue(fq._r is None)in favor of the existingassertIsNone(fq._r).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/test_func.py |
Renames the teardown method to the correct asyncTearDown hook to ensure Redis cleanup executes after each test. |
tests/test_edge_cases.py |
Removes a redundant assertion, keeping the clearer assertIsNone check. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback from PR #4 review thread by fixing test infrastructure issues.
Test lifecycle fix:
test_asyncTearDown()→asyncTearDown()intests/test_func.pyTest assertion cleanup:
assertTrue(fq._r is None)intests/test_edge_cases.pyassertIsNone(fq._r)already present on previous line with better error messages💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.