Skip to content

fix: add cap to image rendering#1621

Merged
andrinoff merged 7 commits into
floatpane:masterfrom
andrinoff:fix/image-display-breaking
Jun 24, 2026
Merged

fix: add cap to image rendering#1621
andrinoff merged 7 commits into
floatpane:masterfrom
andrinoff:fix/image-display-breaking

Conversation

@andrinoff

Copy link
Copy Markdown
Member

What?

Adds a cap to image rendering, so that the images dont break the whole TUI

Why?

Previously, big images would make the whole screen black, when scrolled.

Signed-off-by: drew <me@andrinoff.com>
@andrinoff andrinoff requested a review from a team as a code owner June 24, 2026 12:24
@floatpanebot floatpanebot added bug Something isn't working area/tui Terminal UI / view layer size/M Diff: 51–200 lines backport/v1 Merge to master and backport to release/v1 labels Jun 24, 2026
Signed-off-by: drew <me@andrinoff.com>
Signed-off-by: drew <me@andrinoff.com>
@floatpanebot floatpanebot added the dependencies Dependency updates label Jun 24, 2026
Signed-off-by: drew <me@andrinoff.com>
Signed-off-by: drew <me@andrinoff.com>
Signed-off-by: drew <me@andrinoff.com>
Signed-off-by: drew <me@andrinoff.com>
@andrinoff andrinoff enabled auto-merge June 24, 2026 12:48

@floatpanebot floatpanebot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of @andrinoff via /approve command.

@andrinoff andrinoff added this pull request to the merge queue Jun 24, 2026
Merged via the queue into floatpane:master with commit 8235eaa Jun 24, 2026
29 checks passed
@andrinoff andrinoff deleted the fix/image-display-breaking branch June 24, 2026 12:52
@floatpanebot floatpanebot added the backported Cherry-picked onto release/v1 label Jun 24, 2026
floatpanebot pushed a commit that referenced this pull request Jun 24, 2026
## What?

Adds a cap to image rendering, so that the images dont break the whole
TUI

## Why?

Previously, big images would make the whole screen black, when scrolled.

---------

Signed-off-by: drew <me@andrinoff.com>
(cherry picked from commit 8235eaa)
@floatpane floatpane deleted a comment from andrinoff Jun 24, 2026
@floatpane floatpane deleted a comment from andrinoff Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/tui Terminal UI / view layer backport/v1 Merge to master and backport to release/v1 backported Cherry-picked onto release/v1 bug Something isn't working dependencies Dependency updates size/M Diff: 51–200 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants