Merged
Conversation
Newer boost versions entirely remove the deprecated APIs, so let's fix them now: io_service -> io_context expires_from_now -> expires_after post/dispatch method become free functions strand wrap() -> bind_executor resolver changes that don't fit in this margin Building with BOOST_ASIO_NO_DEPRECATED makes the deprecated API unavailable even in older Boost versions, so set that to provoke errors if the old API is used at all.
Boost.System "has been header-only since 1.69", and the stub library was removed in 1.89 which breaks trying to link to the (now nonexistent) libboost_system. Rather than trying to detect the boost version, just assume that we have at least 1.69 and remove the link dependency entirely. The oldest Debian version we expect to compile against (bullseye) has 1.74 so should be okay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dump978 fails to build against newer Boost versions for a couple of reasons:
boost::asio starting from Boost 1.84 begins to remove support for older deprecated APIs that were used in dump978. Replace the deprecated APIs with the newer versions, and build with BOOST_ASIO_NO_DEPRECATED defined to provoke errors on older boost versions if any deprecated APIs were missed.
Boost >= 1.89 removes libboost_system entirely. The release notes say that Boost.System has been header-only since 1.69, which predates the oldest Debian version we try to build for (bullseye), so just assume that we have >=1.69 and don't try to link against libboost_system at all.