fix(flet-cli): correct dependency parsing (#6332)#6340
Open
td3447 wants to merge 2 commits intoflet-dev:mainfrom
Open
fix(flet-cli): correct dependency parsing (#6332)#6340td3447 wants to merge 2 commits intoflet-dev:mainfrom
td3447 wants to merge 2 commits intoflet-dev:mainfrom
Conversation
Closes issue: flet-dev#6332 - Adds a space (' ') in front of dependencies in `pyproject.toml` that have version constraints starting with `<` or `<=`. - Fixes the issue where `flet build` would give a `The system cannot find the file specified.` error.
Contributor
|
Thank you for your PR! This only fixes |
- Fixed parsing issue for dependencies in [tool.poetry.dependencies] - Adds single space ' ' to the front of the `<` or `<=` to prevent `The system cannot find the file specified.` error.
Author
Updates
Test Code
poetry run flet build windows | apkTests[tool.poetry.dependencies]
✅ chardet = "<=6"
✅ chardet = "<6"
✅ chardet = " < 6 " |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #6332
Summary
Commit message
Closes issue: #6332
pyproject.tomlthat have version constraints starting with<or<=.flet buildwould give aThe system cannot find the file specified.error.Additional Details
pyproject.tomlafter adding dependencies withuv add. uv does have a leading space before the<but withflet builda lack of leading space raises an error.<=or<and bypasses all others, if it has one from the list then it appends a space and adds that to the set.Test Code
Type of change
Summary by Sourcery
Bug Fixes:
<or<=version constraints are formatted with a leading space to avoid build failures when parsingpyproject.tomldependencies.