Repository navigation
Complete user stanza support - #11
Merged
Merged
Conversation
navaneeth-dev
requested review from
elmiko and
tormath1
and
a balanced review from Copilot
October 4, 2026 06:59
Convert supplementary and primary groups, password-lock policy, and sudo rules into equivalent Flatcar Butane configuration. Reject unrepresentable inactive accounts and unsafe generated-configuration usernames. Signed-off-by: Navaneeth <me@rizexor.com>
Signed-off-by: Navaneeth <me@rizexor.com>
Require an explicit primary group when a synthesized group matches a configured username. This prevents Ignition user creation from colliding with Linux private-group creation. Signed-off-by: Navaneeth <me@rizexor.com>
navaneeth-dev
force-pushed
the
feat/users-support
branch
from
October 4, 2026 07:01
587922e to
b890ea0
Compare
elmiko
reviewed
Oct 5, 2026
elmiko
left a comment
elmiko
left a comment
Collaborator
There was a problem hiding this comment.
this is making sense to me, i have a minor question.
also, the documentation work is great, makes it very clear to see the state of the various cloud-init fields. well done!
Collaborator
|
looking good from my side, would like to get a review from @tormath1 about the butane specific portions. |
elmiko
approved these changes
Oct 8, 2026
tormath1
approved these changes
Oct 9, 2026
tormath1
left a comment
tormath1
left a comment
Contributor
There was a problem hiding this comment.
Thanks, it looks good to me. I'm feeling confident with all the tests being added on top of this.
Some tips for the next PRs:
- Mark your PR as "ready for review" when it's ... ready for review :) I tend to not look at review requests when the PR is still "in progress" because you don't know if things are going to evolve in the next days
- Don't hesitate to add a PR description (please not a huge description produced by Claude) but just to give a gist to the reviewers: what's the PR about, any doubts or questions, areas that need more attentions in the review, etc. The review will be more efficient for everyone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.