-
Notifications
You must be signed in to change notification settings - Fork 207
WIP arc #926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
SozinM
wants to merge
5
commits into
msozin/reth11.3
Choose a base branch
from
msozin/ark
base: msozin/reth11.3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
WIP arc #926
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
412643f
Add arc chain support: compile-time chain selection + arc block build…
SozinM b7326c2
Generalize block sink and slot source for engine-driven chains
SozinM 57aad36
Add arc-rbuilder: rbuilder in-process with an arc-node execution node
SozinM d5b15a1
Add arc tests; gate Ethereum-gas-semantics tests under arc feature
SozinM 132fcce
arc-rbuilder: source chain spec from the node; E2E-verified block bui…
SozinM File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| [package] | ||
| name = "arc-rbuilder" | ||
| version.workspace = true | ||
| edition.workspace = true | ||
| rust-version.workspace = true | ||
| license.workspace = true | ||
| homepage.workspace = true | ||
| repository.workspace = true | ||
|
|
||
| [dependencies] | ||
| rbuilder = { workspace = true, features = ["arc"] } | ||
| rbuilder-config.workspace = true | ||
|
|
||
| arc-evm.workspace = true | ||
| arc-evm-node.workspace = true | ||
| arc-execution-config.workspace = true | ||
| arc-execution-payload.workspace = true | ||
| arc-execution-txpool.workspace = true | ||
| arc-execution-validation.workspace = true | ||
|
|
||
| reth.workspace = true | ||
| reth-cli-util.workspace = true | ||
| reth-node-api.workspace = true | ||
| reth-node-builder.workspace = true | ||
| reth-payload-builder.workspace = true | ||
| reth-basic-payload-builder.workspace = true | ||
| reth-ethereum-engine-primitives.workspace = true | ||
| reth-provider.workspace = true | ||
| reth-transaction-pool.workspace = true | ||
| reth-revm.workspace = true | ||
| reth-evm.workspace = true | ||
| reth-chainspec.workspace = true | ||
| reth-node-ethereum.workspace = true | ||
| alloy-consensus.workspace = true | ||
|
|
||
| alloy-primitives.workspace = true | ||
| alloy-rpc-types-beacon.workspace = true | ||
| alloy-rpc-types-engine.workspace = true | ||
| revm.workspace = true | ||
|
|
||
| clap.workspace = true | ||
| eyre.workspace = true | ||
| futures.workspace = true | ||
| tokio.workspace = true | ||
| tokio-util.workspace = true | ||
| tracing.workspace = true | ||
|
|
||
| [target.'cfg(not(target_env = "msvc"))'.dependencies] | ||
| tikv-jemallocator = { workspace = true } | ||
|
|
||
| [features] | ||
| jemalloc = [] | ||
|
|
||
| [[bin]] | ||
| name = "arc-rbuilder" | ||
| path = "src/main.rs" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| # Example rbuilder config for building Arc chain blocks (arc-rbuilder binary). | ||
| # | ||
| # Usage: | ||
| # cargo run -p arc-rbuilder -- node \ | ||
| # --chain arc-testnet \ | ||
| # --rbuilder.config crates/arc-rbuilder/config-arc-example.toml | ||
| # | ||
| # There are no relays and no bidding on Arc: blocks are delivered to Malachite | ||
| # consensus through the engine API (engine_getPayload), so all MEV-Boost | ||
| # related settings (relays, cl_node_url, relay secret keys) are unused. | ||
|
|
||
| log_json = false | ||
| log_level = "info,rbuilder=debug" | ||
| error_storage_path = "/tmp/rbuilder.error.sqlite" | ||
|
|
||
| # Address that collects priority fees while building; the block's true value | ||
| # is paid to the proposer's suggested fee recipient with the payout tx. | ||
| # env: COINBASE_SECRET_KEY | ||
| coinbase_secret_key = "env:COINBASE_SECRET_KEY" | ||
|
|
||
| # arc-rbuilder always builds for the chain the node runs (--chain flag); this | ||
| # value only needs to parse. Keep it matching the node anyway. | ||
| chain = "arc-localdev" | ||
|
|
||
| full_telemetry_server_port = 6060 | ||
| redacted_telemetry_server_port = 6061 | ||
|
|
||
| # Order intake: the in-process txpool subscription is wired automatically; | ||
| # these servers additionally accept bundles / raw txs over ipc/http. | ||
| jsonrpc_server_port = 8645 | ||
| jsonrpc_server_ip = "0.0.0.0" | ||
| ignore_cancellable_orders = true | ||
|
|
||
| # Sub-second blocks: keep simulation lean. | ||
| simulation_threads = 4 | ||
|
|
||
| live_builders = ["mp-ordering", "mgp-ordering"] | ||
|
|
||
| # Required: sparse trie root hash (parallel impl currently disallowed). | ||
| root_hash_use_sparse_trie = true | ||
| root_hash_compare_sparse_trie = false | ||
|
|
||
| [[builders]] | ||
| name = "mgp-ordering" | ||
| algo = "ordering-builder" | ||
| discard_txs = true | ||
| sorting = "mev-gas-price" | ||
| failed_order_retries = 1 | ||
| drop_failed_orders = true | ||
|
|
||
| [[builders]] | ||
| name = "mp-ordering" | ||
| algo = "ordering-builder" | ||
| discard_txs = true | ||
| sorting = "max-profit" | ||
| failed_order_retries = 1 | ||
| drop_failed_orders = true |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Workspace becomes unbuildable without an external checkout. These are
pathdeps into a sibling../../arc-nodecheckout, andcrates/arc-rbuilder(which depends on them unconditionally) is indefault-members(line 31). That means a plaincargo build/cargo check/make lint/make testat the repo root will fail for anyone — and CI — that doesn't havearc-nodechecked out at exactly that relative path. Thearcfeature on therbuildercrate is properly optional, but addingarc-rbuildertodefault-membersdefeats that isolation.Consider one of:
arc-rbuilderfromdefault-members(keep it inmembers), so default builds skip it.pathdeps.Either way, please confirm
cargo checkon a fresh clone (noarc-nodesibling) still succeeds before merge.