Repository navigation
glass: a panel that splits into pieces (across and down) and merges back flat, with no bulge at the seam - #1055
Conversation
Agent-Team: linux Worker: codex
PM note: how this PR will be handledWhat it is for: glass: a panel that splits into pieces (across and down) and merges back flat, with no bulge at the seam Rules that apply: none special. Things to watch (checked by rule):
What happens next:
A living status comment below is kept current. Nothing here is a merge decision. |
Where this PR standsStage: Done: approved What the PM needs before approving (ticks as it is met; the full CI runs only at the end, after the reviews are clean):
Reviews at the current commit (
1 earlier review are for older commits and will be redone. Latest fixes comment: https://github.com/fizzyedit/work/issues/827#issuecomment-6536805928 (9 findings answered) Updated 2026-10-31 10:52 UTC by the PM. This comment is edited in place. |
Agent-Team: linux Worker: codex
Part of fizzyedit/work#823
Rework: work#835
In plain words
Glass panels can split across and down, then merge into one flat surface. A nearby floating drop can change its appearance without changing the panel's frost or bend. This update also makes joins reliable when layout coordinates differ slightly.
What changes
The panel has its own material settings:
What you will notice
The panel keeps its appearance while nearby drops animate. The sequence below shows the neck opening at each requested gap (white is glass, black is empty).
How we know it works
All 21 panel and liquid-field tests pass, including drawing outlines in a headless frame. Restoring the material and coordinate bugs makes the new regression tests fail. The image shows CPU coverage, not a GPU rendering.
How this serves fizzy
Goal: craft, polish and materials: panels keep consistent glass as pieces split and rejoin.
For agents: technical summary
Goal
Part of fizzyedit/work#835; answer linux/claude F1–F9 on PR #1055 at 0d76122.
What changed and why
Panel owns blur/lens independently of free drops. Nested seams match coordinates within float tolerance and use named endpoint modes. CPU/HLSL avoid evaluating box distance before replacing it with panel distance. Generated shaders are refreshed. Documented tangent clustering and the absence of panel pointer light; removed the redundant count clamp. Outline drawing has a headless frame test and optional dumps run in their own test.
How it was verified
See GATES.md for gate results and named sandbox failures. Native build 85/85, web 45/45, SDK version 35/35 and lint 3/3 steps succeeded; formatting passed. Unit and integration gates encounter sandbox socket restrictions. All 21 liquid-field tests pass. Material/coordinate mutations fail their new regressions. The committed coverage image is generated from FIZZY_PANEL_DUMPS at the five requested gaps.
Not done / follow-ups
GPU appearance and CPU/GPU numerical agreement need device verification. Publishing the updated PR page and the single FIXES comment is performed by the harness. No commit, push or GitHub operation was performed in this sandbox.
Changes (12 files, +2772/-1295)
Gates: not run yet
Gates not run yet;
scripts/agent-finish 835replaces this with their output.