Conversation
Member
There was a problem hiding this comment.
suggestion: Generating a client from the openapi instead would be preferred and more educational imo
Member
Author
There was a problem hiding this comment.
I tried to do that with composition api, but failed. The api is generated for Fishjam though
Member
There was a problem hiding this comment.
praise: I'm pretty sure we can just use useLivestreamViewer from @fishjam-cloud/react-client with token and url
roznawsk
force-pushed
the
fishjam-foundry-example
branch
from
ce58d4b to
508b183
Compare
roznawsk
force-pushed
the
fishjam-foundry-example
branch
from
508b183 to
9786ca4
Compare
PiotrWodecki
reviewed
Mar 5, 2026
| @@ -0,0 +1,11 @@ | |||
| module conference-to-stream | |||
|
|
|||
| go 1.24.5 | |||
Member
There was a problem hiding this comment.
suggestion: probably should be the same as Dockerfile
|
|
||
| // Start WS notifier for this room | ||
| fishjamBaseURL := h.fishjamClient.BaseURL() | ||
| _, err = fishjam.NewNotifier(fishjamBaseURL, h.managementToken, fishjam.NotifierCallbacks{ |
| PeerWebsocketURL string `json:"peerWebsocketUrl"` | ||
| } | ||
|
|
||
| func (h *Handler) CreateRoom(w http.ResponseWriter, r *http.Request) { |
Member
There was a problem hiding this comment.
nitpick: there is still very much a race condition here
| @@ -0,0 +1,15 @@ | |||
| FROM node:22-alpine AS builder | |||
| WORKDIR /app | |||
| COPY package.json ./ | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.