Merged
Conversation
ksagiyam
force-pushed
the
ksagiyam/allow_for_ghost_only_mesh
branch
from
e3b7e72 to
b21e65b
Compare
ksagiyam
changed the title
ksagiyam
force-pushed
the
ksagiyam/allow_for_ghost_only_mesh
branch
from
b21e65b to
f391c06
Compare
connorjward
approved these changes
Sep 10, 2024
Contributor
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
Looks fine. I assume in Cython it is fine to replace if ilocal != NULL with if ilocal.
Contributor
Author
|
Thanks! I think it is fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow for ghost only meshes.
plex.pointSF.ilocalis an array of leaf points on each rank. If the array is trivial (i.e.,ilocal = [0, 1, 2, ...]),ilocalis set toNULL. So typically we use this array aspoint = ilocal[i] if ilocal else i, but in some places we simply dopoint = ilocal[I]. This is fine if a rank at least owns one cell (ilocalis nontrivial due to plex point numbering convention) or does not have cells at all, but not fine if the rank sees and only sees ghost cells (ilocalis trivial, soilocalbecomesNULL) . It turned out that we need to handle the latter case if submeshes are involved the submesh PR.