Skip to content

Add optional Search objective and client model flags - #295

Merged
KrisOei merged 5 commits into
mainfrom
feat/search-task-context
Oct 1, 2026
Merged

KrisOei merged 5 commits into
mainfrom
feat/search-task-context

Conversation

@KrisOei

@KrisOei KrisOei commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Adds optional --objective and --client-model flags to Search. Existing commands behave as before.

Requires firecrawl/firecrawl#4881.

Checks

CLI typecheck and Search-command tests passed.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 5 files

Shadow auto-approve: would auto-approve with 2 open P3 issues. Adds optional --objective/--session-id/--client-model flags to the search command, forwarded only when supplied, with docs and tests. Default requests are unchanged and the feature is additive and bounded.

Fix all with cubic | Re-trigger cubic

Comment thread src/__tests__/commands/search.test.ts
Comment thread skills/firecrawl-search/SKILL.md Outdated

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 2 files (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Shadow auto-approve: would require human review. Adds optional agent task context to Firecrawl search requests and CLI flags; depends on an unmerged backend PR, so API compatibility and release sequencing need sign-off.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 5 files (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Shadow auto-approve: would require human review. Adds optional objective/clientModel CLI flags and request forwarding with tests/docs; sessionId dropped. Decisive risk: backend support only claimed via unmerged firecrawl/firecrawl#4881, so API compatibility/release sequencing needs human sign-off.

Re-trigger cubic

@capy-ai capy-ai Bot changed the title feat(search): forward optional agent task context Add optional Search objective flag Oct 1, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 5 files (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Shadow auto-approve: would require human review. Adds an optional --objective flag to Search and forwards it when supplied; clientModel was removed since the prior review. Backend support for the objective field still depends on an unmerged firecrawl PR, so API compatibility and release sequencing need human sign-off.

Re-trigger cubic

@capy-ai capy-ai Bot changed the title Add optional Search objective flag Add optional Search objective and client model flags Oct 1, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 4 files (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Shadow auto-approve: would require human review. Adds optional --objective and --client-model flags to Search and forwards them only when supplied; default requests are unchanged. Approval hinges on unverified backend support via unmerged firecrawl#4881, so release compatibility needs human sign-off.

Re-trigger cubic

@KrisOei
KrisOei merged commit e07a08e into main Oct 1, 2026
8 checks passed
@KrisOei
KrisOei deleted the feat/search-task-context branch October 1, 2026 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant