fix: wait for draining engine before starting again (FIR-50579)#474
Open
fix: wait for draining engine before starting again (FIR-50579)#474
Conversation
|
fstr
changed the title
fstr
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draining is equivalent to stopping so we want to wait for it too before doing any operations with the engine.
Adding this functionality to keep it consistent with how we handle STOPPING and STARTING states.
Currently there would be no breakage as the backend would handle the start/stop mechanism, but this improvement avoids keeping the connection open unnecessarily.