Skip to content

feat: add locale translations for 40 languages#1352

Merged
demolaf merged 2 commits intomainfrom
more-translations
Apr 20, 2026
Merged

feat: add locale translations for 40 languages#1352
demolaf merged 2 commits intomainfrom
more-translations

Conversation

@demolaf
Copy link
Copy Markdown
Member

@demolaf demolaf commented Apr 20, 2026

Adds locale support for 40 languages.

New locales: Arabic, Bulgarian, Catalan, Croatian, Danish, Dutch, Filipino, Finnish, French, German, Greek, Hebrew, Hindi, Hungarian, Indonesian, Italian, Japanese, Korean, Lithuanian, Latvian, Norwegian Bokmål, Persian, Polish, Portuguese (BR), Portuguese (PT), Romanian, Russian, Serbian, Slovak, Slovenian, Spanish (ES), Spanish (Latin America), Swedish, Thai, Turkish, Ukrainian, Vietnamese, Chinese Simplified, Chinese Traditional, English (GB).

All 40 non-English locales have locale-specific tests covering correct locale identifiers, translation references, all categories defined, sample string assertions, fallback to English, and placeholder replacement.

Closes #1348.

Screenshot 2026-04-20 at 14 21 29

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces ten new locales—Arabic, German, Spanish, French, Hindi, Italian, Japanese, Korean, Portuguese, and Chinese—by adding dedicated translation files and exporting pre-registered locale objects. It also includes comprehensive tests to verify translation mapping, category definitions, and fallback mechanisms. The review feedback focuses on maintaining naming consistency with existing exports (e.g., using camelCase like "deDe" instead of "deDE"), removing redundant import aliases, and correcting the Arabic locale identifier to avoid misleading country code associations.

Comment thread packages/translations/src/index.ts Outdated
Comment thread packages/translations/src/index.ts Outdated
Comment thread packages/translations/src/index.test.ts Outdated
Comment thread packages/translations/src/index.test.ts Outdated
@demolaf demolaf changed the title feat: add 10 new locale translations feat: add new locale translations Apr 20, 2026
@demolaf demolaf changed the title feat: add new locale translations feat: add locale translations for 40 languages Apr 20, 2026
@demolaf demolaf merged commit 3bbe28a into main Apr 20, 2026
3 checks passed
@demolaf demolaf deleted the more-translations branch April 20, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support more languages for locale

2 participants