feat: add locale translations for 40 languages#1352
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces ten new locales—Arabic, German, Spanish, French, Hindi, Italian, Japanese, Korean, Portuguese, and Chinese—by adding dedicated translation files and exporting pre-registered locale objects. It also includes comprehensive tests to verify translation mapping, category definitions, and fallback mechanisms. The review feedback focuses on maintaining naming consistency with existing exports (e.g., using camelCase like "deDe" instead of "deDE"), removing redundant import aliases, and correcting the Arabic locale identifier to avoid misleading country code associations.
russellwheatley
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds locale support for 40 languages.
New locales: Arabic, Bulgarian, Catalan, Croatian, Danish, Dutch, Filipino, Finnish, French, German, Greek, Hebrew, Hindi, Hungarian, Indonesian, Italian, Japanese, Korean, Lithuanian, Latvian, Norwegian Bokmål, Persian, Polish, Portuguese (BR), Portuguese (PT), Romanian, Russian, Serbian, Slovak, Slovenian, Spanish (ES), Spanish (Latin America), Swedish, Thai, Turkish, Ukrainian, Vietnamese, Chinese Simplified, Chinese Traditional, English (GB).
All 40 non-English locales have locale-specific tests covering correct locale identifiers, translation references, all categories defined, sample string assertions, fallback to English, and placeholder replacement.
Closes #1348.