Skip to content

chore: update minimum cmake version to 3.22 #1812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AustinBenoit wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: update minimum cmake version to 3.22 #1812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b760743
chore: update minimum cmake version to 3.30
AustinBenoit Jan 8, 2026
ee17782
Chore: update to 3.22
AustinBenoit Jan 8, 2026
c98cc61
fixup: the change now requires a cxx label so its included
AustinBenoit Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

# Top level CMake file that defines the entire Firebase C++ SDK build.

cmake_minimum_required (VERSION 3.1)
cmake_minimum_required(VERSION 3.22)

set (CMAKE_CXX_STANDARD 14)
set (CMAKE_CXX_STANDARD_REQUIRED YES) # Don't fall back to an earlier version.
Expand Down
2 changes: 1 addition & 1 deletion analytics/integration_test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

# Cmake file for a single C++ integration test build.

cmake_minimum_required(VERSION 2.8)
cmake_minimum_required(VERSION 3.22)

find_program(FIREBASE_PYTHON_EXECUTABLE
NAMES python3 python
Expand Down
2 changes: 1 addition & 1 deletion analytics/integration_test/googletest.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
# This CMake file is taken from:
# https://github.com/google/googletest/blob/master/googletest/README.md#incorporating-into-an-existing-cmake-project

cmake_minimum_required(VERSION 2.8.2)
cmake_minimum_required(VERSION 3.22)

project(googletest-download NONE)

Expand Down
2 changes: 1 addition & 1 deletion app/integration_test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

# Cmake file for a single C++ integration test build.

cmake_minimum_required(VERSION 2.8)
cmake_minimum_required(VERSION 3.22)

find_program(FIREBASE_PYTHON_EXECUTABLE
NAMES python3 python
Expand Down
2 changes: 1 addition & 1 deletion app/integration_test/googletest.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
# This CMake file is taken from:
# https://github.com/google/googletest/blob/master/googletest/README.md#incorporating-into-an-existing-cmake-project

cmake_minimum_required(VERSION 2.8.2)
cmake_minimum_required(VERSION 3.22)

project(googletest-download NONE)

Expand Down
2 changes: 1 addition & 1 deletion app/rest/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

# CMake file for the firebase_rest_lib library

cmake_minimum_required (VERSION 3.1)
cmake_minimum_required(VERSION 3.22)
# Firebase C++ SDK requires C++14.
set (CMAKE_CXX_STANDARD 14)
set (CMAKE_CXX_STANDARD_REQUIRED YES) # Don't fall back to an earlier version.
Expand Down
2 changes: 1 addition & 1 deletion app_check/integration_test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

# Cmake file for a single C++ integration test build.

cmake_minimum_required(VERSION 2.8)
cmake_minimum_required(VERSION 3.22)

find_program(FIREBASE_PYTHON_EXECUTABLE
NAMES python3 python
Expand Down
2 changes: 1 addition & 1 deletion app_check/integration_test/googletest.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
# This CMake file is taken from:
# https://github.com/google/googletest/blob/master/googletest/README.md#incorporating-into-an-existing-cmake-project

cmake_minimum_required(VERSION 2.8.2)
cmake_minimum_required(VERSION 3.22)

project(googletest-download NONE)

Expand Down
2 changes: 1 addition & 1 deletion auth/integration_test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

# Cmake file for a single C++ integration test build.

cmake_minimum_required(VERSION 2.8)
cmake_minimum_required(VERSION 3.22)

find_program(FIREBASE_PYTHON_EXECUTABLE
NAMES python3 python
Expand Down
2 changes: 1 addition & 1 deletion auth/integration_test/googletest.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
# This CMake file is taken from:
# https://github.com/google/googletest/blob/master/googletest/README.md#incorporating-into-an-existing-cmake-project

cmake_minimum_required(VERSION 2.8.2)
cmake_minimum_required(VERSION 3.22)

project(googletest-download NONE)

Expand Down
2 changes: 1 addition & 1 deletion cmake/external/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
# setting up ExternalProjects for each dependency, and then building this
# project, which is done via external_rules.cmake, one directory above.

cmake_minimum_required(VERSION 3.1)
cmake_minimum_required(VERSION 3.22)
project(Firebase-cpp-download C CXX)

list(APPEND CMAKE_MODULE_PATH ${CMAKE_CURRENT_LIST_DIR})
Expand Down
2 changes: 1 addition & 1 deletion cmake/external/firebase_ios_sdk.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ if(TARGET firebase_ios_sdk OR NOT DOWNLOAD_FIREBASE_IOS_SDK)
return()
endif()

cmake_minimum_required(VERSION 3.0)
cmake_minimum_required(VERSION 3.22)

set(SDK_VERSION "6.14.0")

Expand Down
2 changes: 1 addition & 1 deletion cmake/toolchains/apple.toolchain.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@
# command.
#

cmake_minimum_required(VERSION 3.8.0)
cmake_minimum_required(VERSION 3.22)

# CMake invokes the toolchain file twice during the first build, but only once during subsequent rebuilds.
if(IOS_TOOLCHAIN_HAS_RUN)
Expand Down
2 changes: 1 addition & 1 deletion database/integration_test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

# Cmake file for a single C++ integration test build.

cmake_minimum_required(VERSION 2.8)
cmake_minimum_required(VERSION 3.22)

find_program(FIREBASE_PYTHON_EXECUTABLE
NAMES python3 python
Expand Down
2 changes: 1 addition & 1 deletion database/integration_test/googletest.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
# This CMake file is taken from:
# https://github.com/google/googletest/blob/master/googletest/README.md#incorporating-into-an-existing-cmake-project

cmake_minimum_required(VERSION 2.8.2)
cmake_minimum_required(VERSION 3.22)

project(googletest-download NONE)

Expand Down
2 changes: 1 addition & 1 deletion firestore/integration_test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

# Cmake file for a single C++ integration test build.

cmake_minimum_required(VERSION 2.8)
cmake_minimum_required(VERSION 3.22)

find_program(FIREBASE_PYTHON_EXECUTABLE
NAMES python3 python
Expand Down
2 changes: 1 addition & 1 deletion firestore/integration_test/googletest.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
# This CMake file is taken from:
# https://github.com/google/googletest/blob/master/googletest/README.md#incorporating-into-an-existing-cmake-project

cmake_minimum_required(VERSION 2.8.2)
cmake_minimum_required(VERSION 3.22)

project(googletest-download NONE)

Expand Down
2 changes: 1 addition & 1 deletion firestore/integration_test_internal/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

# Cmake file for a single C++ integration test build.

cmake_minimum_required(VERSION 2.8)
cmake_minimum_required(VERSION 3.22)

find_program(FIREBASE_PYTHON_EXECUTABLE
NAMES python3 python
Expand Down
2 changes: 1 addition & 1 deletion firestore/integration_test_internal/abseil-cpp.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

cmake_minimum_required(VERSION 2.8)
cmake_minimum_required(VERSION 3.22)
include(ExternalProject)

set(version 20200225)
Expand Down
2 changes: 1 addition & 1 deletion firestore/integration_test_internal/googletest.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
# This CMake file is taken from:
# https://github.com/google/googletest/blob/master/googletest/README.md#incorporating-into-an-existing-cmake-project

cmake_minimum_required(VERSION 2.8.2)
cmake_minimum_required(VERSION 3.22)

project(googletest-download NONE)

Expand Down
2 changes: 1 addition & 1 deletion functions/integration_test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

# Cmake file for a single C++ integration test build.

cmake_minimum_required(VERSION 2.8)
cmake_minimum_required(VERSION 3.22)

find_program(FIREBASE_PYTHON_EXECUTABLE
NAMES python3 python
Expand Down
2 changes: 1 addition & 1 deletion functions/integration_test/googletest.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
# This CMake file is taken from:
# https://github.com/google/googletest/blob/master/googletest/README.md#incorporating-into-an-existing-cmake-project

cmake_minimum_required(VERSION 2.8.2)
cmake_minimum_required(VERSION 3.22)

project(googletest-download NONE)

Expand Down
2 changes: 1 addition & 1 deletion installations/integration_test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

# Cmake file for a single C++ integration test build.

cmake_minimum_required(VERSION 2.8)
cmake_minimum_required(VERSION 3.22)

find_program(FIREBASE_PYTHON_EXECUTABLE
NAMES python3 python
Expand Down
2 changes: 1 addition & 1 deletion installations/integration_test/googletest.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
# This CMake file is taken from:
# https://github.com/google/googletest/blob/master/googletest/README.md#incorporating-into-an-existing-cmake-project

cmake_minimum_required(VERSION 2.8.2)
cmake_minimum_required(VERSION 3.22)

project(googletest-download NONE)

Expand Down
6 changes: 2 additions & 4 deletions ios_pod/empty_CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

# Stub cmake project to enable pod files to be installed against
cmake_minimum_required(VERSION 3.22)
Copy link
Contributor

@a-maurice a-maurice Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the comment?


cmake_minimum_required (VERSION 3.1)

project (GetPods CXX)
project (empty CXX)
Copy link
Contributor

@a-maurice a-maurice Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why rename the project?

add_library(GetPods empty.cc)
2 changes: 1 addition & 1 deletion messaging/integration_test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

# Cmake file for a single C++ integration test build.

cmake_minimum_required(VERSION 2.8)
cmake_minimum_required(VERSION 3.22)

find_program(FIREBASE_PYTHON_EXECUTABLE
NAMES python3 python
Expand Down
2 changes: 1 addition & 1 deletion messaging/integration_test/googletest.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
# This CMake file is taken from:
# https://github.com/google/googletest/blob/master/googletest/README.md#incorporating-into-an-existing-cmake-project

cmake_minimum_required(VERSION 2.8.2)
cmake_minimum_required(VERSION 3.22)

project(googletest-download NONE)

Expand Down
4 changes: 2 additions & 2 deletions release_build_files/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@
# See the License for the specific language governing permissions and
# limitations under the License.

# Top level CMake file that defines targets for the Firebase C++ SDK.
cmake_minimum_required(VERSION 3.22)
Copy link
Contributor

@a-maurice a-maurice Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the comment?


cmake_minimum_required(VERSION 3.1)
project (firebase_prebuilt NONE)
Copy link
Contributor

@a-maurice a-maurice Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of adding the project?


include(FindPkgConfig)

Expand Down
2 changes: 1 addition & 1 deletion remote_config/integration_test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

# Cmake file for a single C++ integration test build.

cmake_minimum_required(VERSION 2.8)
cmake_minimum_required(VERSION 3.22)

find_program(FIREBASE_PYTHON_EXECUTABLE
NAMES python3 python
Expand Down
2 changes: 1 addition & 1 deletion remote_config/integration_test/googletest.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
# This CMake file is taken from:
# https://github.com/google/googletest/blob/master/googletest/README.md#incorporating-into-an-existing-cmake-project

cmake_minimum_required(VERSION 2.8.2)
cmake_minimum_required(VERSION 3.22)

project(googletest-download NONE)

Expand Down
2 changes: 1 addition & 1 deletion storage/integration_test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

# Cmake file for a single C++ integration test build.

cmake_minimum_required(VERSION 2.8)
cmake_minimum_required(VERSION 3.22)

find_program(FIREBASE_PYTHON_EXECUTABLE
NAMES python3 python
Expand Down
2 changes: 1 addition & 1 deletion storage/integration_test/googletest.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
# This CMake file is taken from:
# https://github.com/google/googletest/blob/master/googletest/README.md#incorporating-into-an-existing-cmake-project

cmake_minimum_required(VERSION 2.8.2)
cmake_minimum_required(VERSION 3.22)

project(googletest-download NONE)

Expand Down
2 changes: 1 addition & 1 deletion testing/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

cmake_minimum_required (VERSION 3.1)
cmake_minimum_required(VERSION 3.22)
set (CMAKE_CXX_STANDARD 14)
set (CMAKE_CXX_STANDARD_REQUIRED YES) # Don't fall back to an earlier version.

Expand Down
2 changes: 1 addition & 1 deletion ump/integration_test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

# Cmake file for a single C++ integration test build.

cmake_minimum_required(VERSION 2.8)
cmake_minimum_required(VERSION 3.22)

find_program(FIREBASE_PYTHON_EXECUTABLE
NAMES python3 python
Expand Down
2 changes: 1 addition & 1 deletion ump/integration_test/googletest.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
# This CMake file is taken from:
# https://github.com/google/googletest/blob/master/googletest/README.md#incorporating-into-an-existing-cmake-project

cmake_minimum_required(VERSION 2.8.2)
cmake_minimum_required(VERSION 3.22)

project(googletest-download NONE)

Expand Down
Loading