Repository navigation
fix(cli): prevent workspace timeline and adr documents from using CalmHub resource $ids - #3591
Merged
markscott-ms merged 1 commit intoNov 4, 2026
Conversation
aksharprabhudesai
requested review from
a team,
LeighFinegold,
Thels,
aidanm3341,
grahampacker-ms,
jpgough-ms,
lbulanti-ms,
markscott-ms,
rocketstack-matt and
willosborne
as code owners
October 31, 2026 06:12
github-actions
Bot
added
cli
Member
|
This change makes sense, but would it not be better to add CLI support for timelines, adrs, etc? |
willosborne
approved these changes
Nov 2, 2026
Contributor
Author
I will create an issue for this and claim it |
6 tasks
…mHub resource $ids
aksharprabhudesai
force-pushed
the
fix/3311-workspace-non-resource-type-id
branch
from
November 3, 2026 03:53
31d2294 to
33323ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #3311
timelineandadrhave no CalmHub resource type, so building a CalmHub resource$idfor them incalm workspace neworcalm workspace addassigned a$idof another resource type (such asarchitectures), causingworkspace pushandworkspace bumpto treat them as that resource type.$idform (timeline,adr),promptForDocumentIdnow asks only for a document ID instead of a CalmHub resource scope and type.calm workspace addrejects a conformant CalmHub$idwhen--typeistimelineoradr.calm workspace pushandcalm workspace bumpskip manifest entries whose document type has no CalmHub resource type, even if an existing file on disk has a namespace resource$id.Type of Change
Affected Components
cli/)calm/)calm-ai/)calm-hub/)calm-hub-ui/)calm-lab/)calm-models/)calm-server/)calm-studio/)calm-widgets/)calm-guard/)docs/)shared/)calm-plugins/vscode/)Commit Message Format ✅
Testing
Checklist