Skip to content

Condition the scheduler role on the group Scheduler actually presents #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hannahhoward merged 1 commit into from
Sep 21, 2026
Merged

Condition the scheduler role on the group Scheduler actually presents #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions deploy/app/schedules.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ locals {
schedules_enabled = var.task_runtime == "sqs"
# What EventBridge Scheduler replaces with the tick time, matched literally.
schedule_time_token = "<aws.scheduler.scheduled-time>"
schedule_group_name = "${terraform.workspace}-${var.app}-tasks"
schedule_group_arn = "arn:aws:scheduler:${var.region}:${var.allowed_account_id}:schedule-group/${local.schedule_group_name}"
schedules = {
for schedule in local.schedule_manifest.schedules :
schedule.taskId => schedule
Expand All @@ -29,7 +31,7 @@ locals {
resource "aws_scheduler_schedule_group" "tasks" {
count = local.schedules_enabled ? 1 : 0

name = "${terraform.workspace}-${var.app}-tasks"
name = local.schedule_group_name
}

data "aws_iam_policy_document" "scheduler_assume_role" {
Expand All @@ -40,8 +42,15 @@ data "aws_iam_policy_document" "scheduler_assume_role" {
type = "Service"
identifiers = ["scheduler.amazonaws.com"]
}
# Only this account's schedules, and only the group they live in, as the
# task role in the same stack conditions its own service trust.
# Only this account, and only schedules in this group, as the ECS task role
# in this stack conditions its own service trust.
#
# The source ARN has to be the group rather than a schedule: Scheduler
# presents the group when it assumes the role, and it checks at
# CreateSchedule that the role it was handed is assumable, so a condition
# naming a schedule can never match and every schedule fails with "The
# execution role you provide must allow AWS EventBridge Scheduler to assume
# the role."
condition {
test = "StringEquals"
variable = "aws:SourceAccount"
Expand All @@ -50,7 +59,7 @@ data "aws_iam_policy_document" "scheduler_assume_role" {
condition {
test = "ArnLike"
variable = "aws:SourceArn"
values = ["arn:aws:scheduler:${var.region}:${var.allowed_account_id}:schedule/${terraform.workspace}-${var.app}-tasks/*"]
values = [local.schedule_group_arn]
}
}
}
Expand Down
Loading