Add new endpoint resubmit to FIA API and tests#651
Open
eva-1729 wants to merge 23 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #651 +/- ##
==========================================
+ Coverage 96.53% 96.61% +0.08%
==========================================
Files 49 49
Lines 2108 2129 +21
==========================================
+ Hits 2035 2057 +22
+ Misses 73 72 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
keiranjprice101
requested changes
May 11, 2026
Collaborator
keiranjprice101
left a comment
keiranjprice101
left a comment
There was a problem hiding this comment.
Thanks Eva.
Couple of comments/questions below
| ) | ||
|
|
||
|
|
||
| @JobCreationRouter.post("/job/resubmit", tags=["job creation"]) |
Collaborator
There was a problem hiding this comment.
I think a cleaner API would be /job/{id}/resubmit Then we could also drop the ResubmitJobmodel entirely
| Use this to connect to the broker | ||
| :return: None | ||
| """ | ||
| queue_name = queue_name or self.queue_name |
Collaborator
There was a problem hiding this comment.
Is this queue_name used below? It looks like it still will always bind on self.queue_nameno matter what.
Collaborator
Author
There was a problem hiding this comment.
Oh you're right, simple mistake, I should be just calling queue_name below
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #640
Description