Add a "None" option for remote device#810
Open
Thaumatized wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default the list will have index 0 selected. If no device is selected (ie, first install), this will show the first device in BT list as selected. The device, however, isn't selected and won't work. Logs will show:
And since the list will show the first device as selected, the settings will appear fine for users and they cannot select the correct option as it is selected already.
Adding a "None" option is the simplest solution. This way when the user makes their way to settings, they will immediately see what is wrong and know how to fix it.
Oh also, to the user this issue will look like Q: I bought a KW902 as you advised. The power light comes on and that’s it? from the QA.
Also, I know I am sort of abusing the ToastLevelNone option here. I figured this way no-one needs to translate the None string. Though we could perhaps also consider using a dash?