Skip to content

Update Next.js and the MCP server's hono for open advisories, and keep branch names out of the PR check scripts - #668

Merged
fccview merged 2 commits into
fccview:developfrom
AleytiaFairlight:fix/security-updates
Nov 19, 2026
Merged

fccview merged 2 commits into
fccview:developfrom
AleytiaFairlight:fix/security-updates

Conversation

@AleytiaFairlight

@AleytiaFairlight AleytiaFairlight commented Nov 19, 2026 •

Copy link
Copy Markdown

Updates the three dependencies on develop that still have open advisories, and closes a script injection in the PR check workflow.

Dependencies

  • next and eslint-config-next 16.4.1 → 16.4.6. 16.4.5 fixes two cache leaks across root params in 'use cache' functions (GHSA-mfr8-8qww-v76h, GHSA-vc7v-qv4w-wrv8, moderate); 16.4.6 is the current 16.4 patch. In yarn.lock only next and the @next/* packages change.

  • mcp-server: hono 4.13.11 → 4.13.18 and @hono/node-server 2.1.3 → 2.1.8. Both come in through @modelcontextprotocol/sdk 1.32.2, whose ranges (^4.11.4, ^1.19.9 || ^2.0.5) already allow them, so only those two entries change in bun.lock. This fixes:

    4.13.18 and 2.1.8 are the newest releases that are more than a week old; the fixes landed in 4.13.16 and 2.1.6.

After this, an OSV scan of yarn.lock and mcp-server/bun.lock finds no open advisories.

PR check workflow

pr-checks.yml expanded ${{ github.head_ref }} straight into its shell scripts. A branch name is chosen by whoever opens the PR, and Git allows names such as $(curl${IFS}…), so such a PR would run that command on the runner. The branch names now reach the scripts as environment variables, and the checks themselves are unchanged.

Checked locally, with the same steps as PR Checks

  • Node 24.22.1 and Yarn 1.22.22:
    • yarn install --frozen-lockfile
    • yarn lint: 0 errors. The 6 warnings are the same on develop.
    • yarn tsc --noEmit
    • tests/security: 311 passed.
    • tests/api: 547 passed.
    • tests/server-actions: 990 passed, 11 skipped.
  • Bun 1.4.4, in mcp-server:
    • bun install --frozen-lockfile; a plain bun install leaves the lockfile unchanged.
    • bun run typecheck
    • bun test: 90 passed.
    • bun run build

Summary by CodeRabbit

  • Chores
    • Updated project maintenance tooling and refined pull request checks. These changes do not alter the app’s user-facing functionality.

@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The workflow passes source and target branch names to shell steps through environment variables. The branch check still rejects pull requests targeting main unless the source branch is develop. The next dependency and eslint-config-next devDependency versions both change from 16.4.1 to 16.4.6.

Suggested reviewers: fccview

Change: Other

Merge Risk: Minimal · up to cb7d2

This change updates Next.js dependencies and hardens PR check scripts against branch-name injection. No actionable merge-blocking risk was found.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the two main changes: updating Next.js and the MCP server's hono dependencies for open advisories, and keeping branch names out of the PR check scripts. The raw summary shows the workf…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the two main changes: updating Next.js and the MCP server's hono dependencies for open advisories, and keeping branch names out of the PR check scripts. The raw summary shows the workflow change (branch names passed via HEAD_REF and BASE_REF environment variables) and the package.json bumps for next and eslint-config-next. The title is specific and matches the changeset. It is long at 111 characters and 20 words, but it still conveys the primary changes. The raw summary does not list the mcp-server hono update, but the excluded lock files and PR objectives cover it.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d50f2229-21fe-4e55-aedf-8d70cbb436c7
Commits

Reviewing files that changed from the base of the PR and between cdc4cf9 and cb7d2d2.

Files ignored due to path filters: 2

  • mcp-server/bun.lock is excluded by !**/*.lock
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
Files selected for processing: 2

  • .github/workflows/pr-checks.yml
  • package.json

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

@fccview
fccview merged commit a60f716 into fccview:develop Nov 19, 2026
4 checks passed
@fccview

fccview commented Nov 19, 2026

Copy link
Copy Markdown
Owner

Thank you!
The nextjs cve was published right after I released 😮‍💨♥️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants