fix(gui): prevent options menu crash due to null advanced display window#211
Draft
fbraz3 wants to merge 1 commit into
Draft
fix(gui): prevent options menu crash due to null advanced display window#211fbraz3 wants to merge 1 commit into
fbraz3 wants to merge 1 commit into
Conversation
Add null checks before winHide() is called on WinAdvancedDisplay in both GeneralsMD and Generals OptionsMenu.cpp. In the base game (Generals), WinAdvancedDisplayOptions is not defined in the wnd file, leading to WinAdvancedDisplay being nullptr and causing a segmentation fault when entering Options. Fixes #192
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #192
Context
When entering the Options menu in the base game (Command & Conquer Generals), the game crashes with a segmentation fault.
Changes
WinAdvancedDisplay->winHide()insideOptionsMenu.cpp(both inGeneralsMDandGenerals) with anif (WinAdvancedDisplay)check.WinAdvancedDisplayOptions, which leads to theWinAdvancedDisplaypointer beingnullptrand causing the segfault upon dereferencing.