fix: resolve beta-13 regressions (strategy center, tree render)#210
Merged
Conversation
…ressions - SpecialPowerModule: Universalize m_availableOnFrame initialization to 0 instead of 0xFFFFFFFF when RETAIL_COMPATIBLE_CRC is disabled. This resolves the regression where USA Command Center (Spy Satellite) and Strategy Center (Battle Plans) buttons were visually enabled but non-functional due to infinite frame recharge math upon unpausing. - W3DTreeBuffer: Fix segfault by properly capturing the isLegacyGrid flag from WorldHeightMap::countTiles and passing it to WorldHeightMap::readTiles. Fixes #206
Removed the legacy `LogSkinRender` debug function and its call in `dx8renderer.cpp`, which was needlessly writing to `logs/skin_render.log` during gameplay.
Restored `!TheFramePacer->isGameHalted()` check in the `GameEngine::update()` loop for both Generals and Zero Hour. This fixes a regression from TheSuperHackers sync where the game logic and background units continued to tick and animate even when the Esc menu was opened.
Caball009
reviewed
Jul 13, 2026
Replaces the naive loop check with upstream's 'fa2761324' fix which prevents logic time accumulator buildup while the game is halted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This draft PR addresses multiple regressions introduced in Beta-13, primarily focusing on fixing crashes and broken logic introduced by the deterministic math and grid layout changes.
Note: This is currently a draft as we are still investigating the pause mechanism bug.
Fixes #206
Changes
#if RETAIL_COMPATIBLE_CRCrestriction inSpecialPowerModule.cpp, consistently initializingm_availableOnFrameto 0. This fixes the regression where targetless powers (like USA Command Center Spy Satellite and Strategy Center Battle Plans) remained visually enabled but functionally inactive due to an integer overflow during timer recharge.W3DTreeBuffer::updateTexture()to properly capture theisLegacyGridflag output fromWorldHeightMap::countTilesand pass it toWorldHeightMap::readTiles. This fixes theEXC_BAD_ACCESSsegfault during post-intro scene rendering caused by uninitialized texture tiles on legacy sheets.LogSkinRenderdebug function indx8renderer.cppto prevent unnecessary writes tologs/skin_render.log.