feat: add support for import tags#252
Conversation
|
Realized I should also add the following:
|
| */ | ||
| testFunction(){ | ||
|
|
There was a problem hiding this comment.
is this spaces need to be changed?
There was a problem hiding this comment.
No, just an auto formatting thing from my editor. Tests are passing with the change, so figured it was ok to keep
There was a problem hiding this comment.
Added them back just in case there was any deliberate whitespace cleaning being tested 👍
|
LGTM |
|
Release v1.5.0 Thank you |
| : `{${typeString}}`; | ||
| importClauses.push(namedImportClause); | ||
| } | ||
| spec.description = `${importClauses.join(", ")} from "${src}"`; |
There was a problem hiding this comment.
I noticed with this release I’ve lost my single quoted import paths and I think this could be the source. Does the prettier singleQuote option need to be checked here and the quotes modified accordingly?
There was a problem hiding this comment.
Thank you for reporting this.
Yes it is related to this pr
I think we should use prettier to format import, it can handle all other configs like space, import sort and others.
There was a problem hiding this comment.
@hosseinmd If you want to fix lmk, otherwise I'll plan to refactor to use prettier some time tonight when I'm free
Implemented the feature requested here
Features
Example
Before
After
Limitations