Skip to content

test: prettier version bump into 3.6#248

Merged
fardad-dev merged 4 commits intofardad-dev:masterfrom
cagataysayg:master
Jul 1, 2025
Merged

test: prettier version bump into 3.6#248
fardad-dev merged 4 commits intofardad-dev:masterfrom
cagataysayg:master

Conversation

@cagataysayg
Copy link
Copy Markdown
Contributor

@cagataysayg cagataysayg commented Jul 1, 2025

Prettier 3.6 has some rule changes, updated the test flow to match the version.

https://prettier.io/blog/2025/06/23/3.6.0#other-changes

Note: Needs approval for running tests on Github actions.

@cagataysayg cagataysayg marked this pull request as draft July 1, 2025 09:36
@cagataysayg
Copy link
Copy Markdown
Contributor Author

@hosseinmd Could you run the workflow to verify if the tests are passing.

@fardad-dev
Copy link
Copy Markdown
Owner

could you fix it to support both versions [3.0,3.6]
i think we could remove failed part of test because it's not related to this plugin.

@cagataysayg
Copy link
Copy Markdown
Contributor Author

cagataysayg commented Jul 1, 2025

I've re-added prettier 3.0 and removed prism-core.js and related test files.

Question: Should I also remove prism-dependencies.js?

@cagataysayg cagataysayg marked this pull request as ready for review July 1, 2025 13:31
@fardad-dev
Copy link
Copy Markdown
Owner

I mean remove lines of code in prism-core.js which failed

@cagataysayg
Copy link
Copy Markdown
Contributor Author

Removed the _self definition part only, which was throwing the error.

@fardad-dev fardad-dev merged commit 2c6d363 into fardad-dev:master Jul 1, 2025
@fardad-dev
Copy link
Copy Markdown
Owner

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants